Code Monkey home page Code Monkey logo

Comments (3)

ixdy avatar ixdy commented on May 18, 2024

Looking at the OCI spec (and what is implemented in client/v2_2/docker_image_list_.py) we may also need to support os.features, os.version, and probably features too. (The golang image uses os.version for the windows images, for example.)

I'm not sure what the cleanest way to do this is. I don't think we can really add all of those fields to --platform in a manageable way, though.

from containerregistry.

nlopezgi avatar nlopezgi commented on May 18, 2024

@ixdy afaik rules_docker is the main user of this repo, so breaking changes (as long as we follow up with PR in rules_docker) should be fine. My preference is option 1.

from containerregistry.

jonjohnsonjr avatar jonjohnsonjr commented on May 18, 2024

@ixdy if you want one flag to fit all of this in, you could change --platform to accept a json blob and just pass that through to resolve, though for interactive use that is probably more cumbersome than --os and --architecture flags (et al).

from containerregistry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.