Comments (3)
Please do not do this. Expose exactly and only the APIs you intend to expose. Looking at that file, most of those constants would be unacceptable to expose outside the library.
from conscrypt.
@davidben SGTM. We already expose one constant value (albeit associated with a particular engine instance) here. It probably makes sense to follow suit with any specific constants that we wish to expose. What I'm currently thinking could be useful would be:
- SSL3_RT_HEADER_LENGTH
- SSL3_RT_MAX_PACKET_SIZE
- SSL3_RT_MAX_PLAIN_LENGTH
Does that seem reasonable?
from conscrypt.
@kruton and @davidben, I just noticed that NativeConstants and all of its constants are already public. The class is marked with @hide
in the javadoc, but that seems rather insufficient to address @davidben's concerns. I suspect we should do something here.
from conscrypt.
Related Issues (20)
- Decrypt conscrypt code
- Additional secure PSK cipher suites
- Need help to understand this point of validating the trust. HOT 2
- signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x10000012c HOT 6
- Virtual thread pinning using Conscrypt with Socket APIs HOT 5
- jmigrate reports errors with org.conscrypt.Platform library HOT 1
- Remove sun.security.x509 dependency
- Can armeabi architecture be supported?
- May I ask how to build Android so files? HOT 2
- OpenSSLX509CRLEntry.hasUnsupportedCriticalExtension shouldn't call X509_supported_extensions HOT 2
- Sangat Berpuas Hati Dengan meneruskan, anda bersetuju Google menggunakan jawapan, maklumat akaun & sistem anda untuk meningkatkan perkhidmatan, mengikut Privasi & Syarat kami . HOT 1
- Native crash with latest BoringSSL HOT 8
- Recommended way to use Pre-Shared Key ?
- OkHttp Websocket connection failing few seconds after getting connected
- RSA "NoPadding" encryption is considered not secure but required by conscrypt to support TLS RSA-PSS signing algorithm HOT 8
- SSP... VLMC.Hammer HOT 2
- Compatibility Issue with GLIBC 2.12 on CentOS 6
- how to mock chrome tls or ja3 fingerprint?
- Is there a plan to change the pseudo random number code from SHA-1 to SHA-2?
- libconscrypt_jni.so is not 16kb aligned for Android HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from conscrypt.