JDK16+ --add-exports not working as expected about compile-testing HOT 5 CLOSED

Hi @cpovirk, thanks for the response!
Unfortunately both tips didn't work:

• Passing -J type flags to the compiler via Java Compiler API is not supported (J flag is not in the BASIC OptionGroup)

• Passing those options to the JVM also didn't do anything (attaching a screnshot below in case I misunderstood what you meant by that)

EDIT: Apologies, I was setting the options on the wrong text field (program arguments). Everything worked once I set them as VM options (Modify Options -> Add VM options).
P.S they need to be set without the -J prefix.

Thanks alot @cpovirk!

from compile-testing.

Great, I'm glad it worked!

I wonder if we should have Compile-Testing produce an error if anyone tries to pass it these flags. The error could advise people what to do instead.

that sounds like a nice improvement, i'd like to try to contribute this. will get on it this week

from compile-testing.

My memory on this is fuzzy, but I want to say that you need to pass those as -J options (-J--add-exports=jdk.compiler/...) and/or that you need to set them on the original test VM rather than trying to pass them to Compiler.javac().withOptions, maybe?

I'd probably try the latter, given that it's what Error Prone does for its maven-surefire-plugin run.

from compile-testing.

Great, I'm glad it worked!

I wonder if we should have Compile-Testing produce an error if anyone tries to pass it these flags. The error could advise people what to do instead.

from compile-testing.

@cpovirk can you please take a look at the attached PR?
Thanks!

from compile-testing.