Error in LinkBuiltinLibrary about clspv HOT 5 CLOSED

Functions that contain those names (frexp, modf, etc...) in their name and have a correct signature seem to trigger it. For example:

void as_long_as_contains_frexp_in_name(float, int *) {}

godbolt: https://gcc.godbolt.org/z/aT6a6ExWo

from clspv.

I guess Builtins::BuiltinWithGenericPointer needs to be improved. Can you submit a PR that fix your usecase?

from clspv.

Or maybe you could add functions declaration in GetEquivalentBuiltinsWithoutGenericPointer only if they are part of library (from LinkBuiltinLibrary). Using something like library->getFunction(<name>)?

from clspv.

Thanks for the suggestions... I'll have a look!
I have a question though: Why does Builtins::BuiltinWithGenericPointer check for names containing the function name and not for an exact match?

from clspv.

I guess an exact match is not very nice because of the mangling. We would have to consider every type.

But another solution could be to have more than just frexp and check for everything except the types. In that case we could also check with starts_with instead of contains. Maybe that would be enough and simpler to implement.

from clspv.