AutoFactory checkNotNull index in error message is 1-indexed, despite java being 0-indexed about auto HOT 5 CLOSED

I went back and looked at the change that introduced these index numbers, and found this from @ronshapiro in the review comments: "I didn't include the actual parameter name for Proguard obfuscation reasons." (cl/126078797 for those who have access.) I wonder if we could do something similar to AutoValue, which has a -A option you can use if you don't want identifiers in the generated code. We'd have to reverse the polarity here, though, since presumably there is lots of Android code that would suddenly get much bigger. Or it could be a new boolean element inside @AutoFactory.

At Google we have @AutoFactory methods with 80 parameters, so telling you that parameter 43 was null isn't all that helpful.

Anyway I think we could at least add text like "first argument is 1" to the message.

from auto.

Probably just saying "Argument number 1" rather than "Argument index 1" would be enough for the rewording? We often index from 0, but we don't usually number things from 0.

[I'm trying not to be bothered by the wording of the rest of the message. The argument is null, but it's the parameter that is @Nullable.]

from auto.

from auto.

I think "number 1" is also probably a source of confusion, though possibly less. I vote for adding the start index/number is best. Or something like argument 1 of 7

from auto.

from auto.