Impossible to create multiple instances of MakePaymentModule class about react-native-make-payment HOT 5 CLOSED

@stephenmcd, @JlUgia Could you have a look at this, please? Or is it better to raise this ticket somewhere else?

from react-native-make-payment.

Hi @stephenmcd. Thanks for the prompt response!

In the scenario you mentioned, everything is fine, but please check this commit with my changes and comments, which will help you reproduce the issue: 9120b25

Just for a demo, I've replaced the image link, as the previous one wasn't working.

from react-native-make-payment.

Thank you so much for the code sample. I was able to reproduce the error and I just released version 0.1.1 to NPM with the fix: e1a35f0

from react-native-make-payment.

Thanks for the report, this is definitely the correct place for it. We'll update here once we have a resolution.

from react-native-make-payment.

Hi, I wasn't able to reproduce the error, although there's no doubt you're somehow getting it.

You'll need to provide more info (preferably some code to try) showing how you're creating and reusing the paymentMethods arg in PaymentRequest(paymentMethods, paymentDetails).

Here's what I tried by editing the included demo app, but it did not produce the error:

// this line is in the demo app
const paymentRequest = new PaymentRequest(paymentMethods, paymentDetails);

// added these, but no error
const paymentMethodsSameObj = [paymentMethods[0]];
const paymentRequestObj = new PaymentRequest(paymentMethodsSameObj, paymentDetails);
const paymentMethodsNewObj = [Object.assign({}, paymentMethods[0])];
const paymentRequestNewObj = new PaymentRequest(paymentMethodsNewObj, paymentDetails);

What you're doing must differ from this.

from react-native-make-payment.