Code Monkey home page Code Monkey logo

Comments (5)

joaogui1 avatar joaogui1 commented on September 28, 2024

I would like to implement this issue!

from optax.

mtthss avatar mtthss commented on September 28, 2024

Awesome! Looking forward to your contribution!

Couple of suggestions:

Please move the bias correction code out of scale_by_adam into a standalone fn:

def _bias_correction(moment, decay, count):
  """Perform bias correction. This becomes a no-op as count goes to infinity."""
  bias_correction = 1 - decay**count
  return jax.tree_map(lambda t: t / bias_correction.astype(t.dtype), moment)

Then add both a scale_by_belief in transform.py and a adabelief optimiser in alias.py.

Thanks!

from optax.

mtthss avatar mtthss commented on September 28, 2024

Thanks @joaogui1 !

from optax.

mtthss avatar mtthss commented on September 28, 2024

We had to briefly revert the change since there was a merging issue,
your PR has now been resubmitted (still with you as author).

from optax.

8bitmp3 avatar 8bitmp3 commented on September 28, 2024

AdaBelief has been documented #83 thanks everyone 👍

from optax.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.