Comments (7)
@ttshivers I like this idea! Is there any action item/follow up that us, the library Authors can do? Updating documentation? Improving the module API?
Feel free to propose and i'd be happy to review/discuss
from nestjs.
I think this could be accomplished with an internal change where the publish method uses a separate connection that we would also need to set up.
from nestjs.
I think this could be accomplished with an internal change where the publish method uses a separate connection that we would also need to set up.
Do you have a change proposal in mind or something you could show off in a PR? I haven't used the rmq package in awhile so I'm open to suggestions
from nestjs.
I think this could be accomplished with an internal change where the publish method uses a separate connection that we would also need to set up.
Do you have a change proposal in mind or something you could show off in a PR? I haven't used the rmq package in awhile so I'm open to suggestions
Sure. Also, I think this may involve changing the names of many public properties to properly differentiate between the consumer and producer connections.
would become
consumerConnection
and there would also be a publisherConnection
.from nestjs.
I think this could be accomplished with an internal change where the publish method uses a separate connection that we would also need to set up.
Do you have a change proposal in mind or something you could show off in a PR? I haven't used the rmq package in awhile so I'm open to suggestions
Sure. Also, I think this may involve changing the names of many public properties to properly differentiate between the consumer and producer connections.
would become
consumerConnection
and there would also be apublisherConnection
.
I like that idea! I'm not against a change of API if it's for the better, again this API should evolve and there's room for improvement
from nestjs.
One thing I'm considering as well is cases where only consumption is used so a publisher channel wouldn't be needed.
Separate connections can be created with the current state by registering the module multiple times so perhaps that might be the way to go.
from nestjs.
A while ago i had the idea of "connection pooling" because it felt that some connections were being recreated and could potentially be re-used but if you do have an RFC feel free to propose, don't feel limited
from nestjs.
Related Issues (20)
- @nestjs-plus/discovery possible issue with nestjs 10.3.0 HOT 1
- ERROR Error: Channel closed by server: 404 (NOT-FOUND) with message "QueueNotExist, ReqId:659E6FF13837453200DC44F9, ErrorHelp[queue=amq.rabbitmq.reply-to,consumerTag=null,autoAck, https://c.tb.cn/F3.Zro5uI]" HOT 1
- RabbitMQ publish doesn't take advantage of amqp-connection-manager's reliable publish HOT 2
- `Subscribe handlers should only return void` logged if using RpcException or RpcExceptionFilter HOT 4
- Support pre-defined consumer tag HOT 1
- [RabbitMQ] AmqpConnection.request() unhandled exception when losing connection HOT 2
- Gracefully shutdown rabbitmq subscribers HOT 6
- Support Module register with undefined config: RabbitMQModule.forRoot(RabbitMQModule, undefined) HOT 1
- consumer won't re attach to a queue when rabbitmq cluster gets restarted in 1/5 cases
- discover graphql mutations, queries, subscriptions? HOT 2
- Publish new release for @golevelup/nestjs-rabbitmq HOT 1
- Param error in stripe.checkout.sessions.listLineItems
- Publish on AmqpConnection not returning boolean? HOT 1
- Can not npm install on a new project due to reflect-metadata peerDependency HOT 6
- Logging Errors
- @golevelup/ts-jest default mocks return an empty object which is inconsistent with jest.fn() which returns undefined.
- @golevelup/nestjs-rabbitmq- error when publish message: Channel closed
- ts-jest - When function is called with a mock, toHaveBeenCalledWith() always succeed even when it should not
- rabbitmq: allow per subscriber/handler deserializer customization HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nestjs.