Code Monkey home page Code Monkey logo

Comments (7)

underfisk avatar underfisk commented on June 9, 2024

@ttshivers I like this idea! Is there any action item/follow up that us, the library Authors can do? Updating documentation? Improving the module API?
Feel free to propose and i'd be happy to review/discuss

from nestjs.

ttshivers avatar ttshivers commented on June 9, 2024

I think this could be accomplished with an internal change where the publish method uses a separate connection that we would also need to set up.

from nestjs.

underfisk avatar underfisk commented on June 9, 2024

I think this could be accomplished with an internal change where the publish method uses a separate connection that we would also need to set up.

Do you have a change proposal in mind or something you could show off in a PR? I haven't used the rmq package in awhile so I'm open to suggestions

from nestjs.

ttshivers avatar ttshivers commented on June 9, 2024

I think this could be accomplished with an internal change where the publish method uses a separate connection that we would also need to set up.

Do you have a change proposal in mind or something you could show off in a PR? I haven't used the rmq package in awhile so I'm open to suggestions

Sure. Also, I think this may involve changing the names of many public properties to properly differentiate between the consumer and producer connections.

get connection(): Connection {

would become consumerConnection and there would also be a publisherConnection.

from nestjs.

underfisk avatar underfisk commented on June 9, 2024

I think this could be accomplished with an internal change where the publish method uses a separate connection that we would also need to set up.

Do you have a change proposal in mind or something you could show off in a PR? I haven't used the rmq package in awhile so I'm open to suggestions

Sure. Also, I think this may involve changing the names of many public properties to properly differentiate between the consumer and producer connections.

get connection(): Connection {

would become consumerConnection and there would also be a publisherConnection.

I like that idea! I'm not against a change of API if it's for the better, again this API should evolve and there's room for improvement

from nestjs.

ttshivers avatar ttshivers commented on June 9, 2024

One thing I'm considering as well is cases where only consumption is used so a publisher channel wouldn't be needed.

Separate connections can be created with the current state by registering the module multiple times so perhaps that might be the way to go.

from nestjs.

underfisk avatar underfisk commented on June 9, 2024

A while ago i had the idea of "connection pooling" because it felt that some connections were being recreated and could potentially be re-used but if you do have an RFC feel free to propose, don't feel limited

from nestjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.