Replace encoding/json with jsoniter about jwt HOT 3 CLOSED

fredbi commented on Sep 6, 2019

Attention: notice that this breaks compatibility with older golang versions.
I don't think that keeping a compatibility promise back to versions older than 1.7 brings much value.
This PR imposes golang 1.7+.

from jwt.

Thanks for all the effort @lggomez :)

I am inclined to close this as "won't fix". I would argue that keeping this library with 0 dependencies is one of the best, not the best feature of this library. Especially looking at the other libraries that tend to have quite a few deps.

from jwt.

Thanks for all the effort @lggomez :)

Thanks! trying to get rid of some management debt in here since I'm not very active on the repo due to schedule

I am inclined to close this as "won't fix". I would argue that keeping this library with 0 dependencies is one of the best, not the best feature of this library. Especially looking at the other libraries that tend to have quite a few deps.

I agree that possibly the best feature is the premise of strict stdlib dependency but I still found this issue interesting to discuss. The json marshaler overhead is almost neglegible on signing time since all of that CPU load goes to crypto but it'd be interesting to see how the parser performs (I see there aren't any benchmarks on that part yet)

from jwt.