🤔 Trailer Headers? about fiber HOT 12 CLOSED

I @Fenny @erikdubbelboer I really appreciate your attention to my question. I believe we can close this issue because there is an alternative.

from fiber.

What will the trailers be used for? Is your response body so big that you can't wait with returning the initial headers until it is completely generated? I'm curious as I have never seen a use case for trailers before.

from fiber.

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template!

from fiber.

@rhodee, I will leave this issue open for now. I will take a look at the RFC 7230 and see if we can help out to implement this in fasthttp.

You could ask @erikdubbelboer here if he could help implementing this, he is one of the core maintainers of fasthttp.

from fiber.

I will do just that @Fenny thank you for giving this a look!

from fiber.

@rhodee I'm guessing we are talking about receiving Trailers here or responding with Trailers? At least not sending them in an outgoing request right?

from fiber.

Hi @erikdubbelboer I am seeking an approach where I can define Trailer Headers, then set them after writing the chunk response. I think the semantics which best capture my intent are in this URL:

https://golang.org/pkg/net/http/#example_ResponseWriter_trailers

Does that make sense? If not I can try to explain further.

from fiber.

The problem I'm having with this is that fasthttp will always wait with sending a response until the handler function has returned. The only ways to send the response body after the handler has returned are SetBodyStream() and SetBodyStreamWriter(). These functions allow you to either specify an io.Reader to read the body from or write it yourself to an bufio.Writer. Neither of these give us the ability to allow you to add trailers after it all.

So to be able to send Trailers we'll need to add some form of API that allows you to set these after the handler has returned already.

In your use case, what are you using? SetBodyStream or SetBodyStreamWriter?

from fiber.

@erikdubbelboer this is a very helpful discussion. I am starting the fiber project from scratch (moving away from a gRPC implementation) and wanted to use Trailers (which I have in my gRPC implementation). So it is a clean slate 😄

from fiber.

Is your response body so big that you can't wait with returning the initial headers until it is completely generated?

They will not be. I use the trailer for timings or arbitrary messages, however it is trivial to meet my needs without Trailers.

from fiber.

Thanks @erikdubbelboer for jumping in 👍

from fiber.

In my case I'm using trailer headers to notify a down stream proxy to purge session since it is expensive to find out whether the session is done unless the body is completely generated. It is not a deal breaker to not support trailer but it still would be nice to have.

from fiber.