🐛 [Bug]: route (and Route()) property from fiber context returning nil when called after body limit error about fiber HOT 6 OPEN

ok, we will consider it for v3
and handle it better

from fiber.

simliar to our check

fiber/app.go

Lines 1094 to 1095 in 9b0a99b

	case errors.Is(err, fasthttp.ErrBodyTooLarge):
	err = ErrRequestEntityTooLarge

One thing that i noticed is that Params from ctx.Route().Params return an empty slice when this case happens, so to solve this internally before a possible update from fiber is to create a helper function, something like this:

func AllParams(c *fiber.Ctx) map[string]string {
	route := c.Route()

	if len(route.Params) == 0 {
		return nil
	}

	return c.AllParams()
}

Maybe help someone with the same problem.

from fiber.

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

from fiber.

interesting
i guess because body limit is an error which is handled on the fasthttp level and the parameters and routing comes after that

can you share the panic error

in this case, you probably have to check your own error handler for this error first and handle it without any further information

from fiber.

simliar to our check

from fiber.

interesting i guess because body limit is an error which is handled on the fasthttp level and the parameters and routing comes after that

can you share the panic error

in this case, you probably have to check your own error handler for this error first and handle it without any further information

If the allParams expect always have a value in route property instead of a nil value, this doesn't mean that the function maybe need a change to check if the route is nil or not? maybe in a v3 of fiber?

The panic:

"runtime error: invalid memory address or nil pointer dereference"
Stack:
	 4  0x0000000000af3319 in github.com/gofiber/fiber/v2.(*Ctx).AllParams
	     at /home/gabrielclaudinomarinho/go/pkg/mod/github.com/gofiber/fiber/[email protected]/ctx.go:1017
	 5  0x0000000001426625 in api.example/pkg/app.customErrorHandler
	     at /home/gabrielclaudinomarinho/projects/api.example/pkg/app/app.go:89
	 6  0x0000000000aea62d in github.com/gofiber/fiber/v2.(*App).ErrorHandler
	     at /home/gabrielclaudinomarinho/go/pkg/mod/github.com/gofiber/fiber/[email protected]/app.go:1061
	 7  0x0000000000aeab71 in github.com/gofiber/fiber/v2.(*App).serverErrorHandler
	     at /home/gabrielclaudinomarinho/go/pkg/mod/github.com/gofiber/fiber/[email protected]/app.go:1093
	 8  0x0000000000b1b7a5 in github.com/gofiber/fiber/v2.(*App).serverErrorHandler-fm
	     at <autogenerated>:1
	 9  0x0000000000a50f87 in github.com/valyala/fasthttp.(*Server).writeErrorResponse
	     at /home/gabrielclaudinomarinho/go/pkg/mod/github.com/valyala/[email protected]/server.go:2850
	10  0x0000000000a4d5c5 in github.com/valyala/fasthttp.(*Server).serveConn
	     at /home/gabrielclaudinomarinho/go/pkg/mod/github.com/valyala/[email protected]/server.go:2287
	11  0x0000000000a63c05 in github.com/valyala/fasthttp.(*Server).serveConn-fm
	     at <autogenerated>:1
	12  0x0000000000a5f077 in github.com/valyala/fasthttp.(*workerPool).workerFunc
	     at /home/gabrielclaudinomarinho/go/pkg/mod/github.com/valyala/[email protected]/workerpool.go:224
	13  0x0000000000a5eda5 in github.com/valyala/fasthttp.(*workerPool).getCh.func1
	     at /home/gabrielclaudinomarinho/go/pkg/mod/github.com/valyala/[email protected]/workerpool.go:196

from fiber.