Comments (6)
@yossizahn, you have a good point and we can provide an Immutable
option so return values within the handler are immutable. Update the docs that by default all context values are valid until you return from the handler. This way we can keep zero memory allocation conversion enabled by default.
func main() {
app := fiber.New(&fiber.Settings{
Immutable: true,
})
app.Get("/:number", func(c *fiber.Ctx) {
number := c.Params("number") // immutable
go func() {
time.Sleep(1 * time.Second)
fmt.Println("number: ", number)
}()
})
app.Listen(3000)
}
from fiber.
Thanks for opening your first issue here! ๐ Be sure to follow the issue template!
from fiber.
We use the same method as Fasthttp to convert strings and bytes without memory allocation, but proper use requires you to never change the original byte array, but that's a reasonable contract in many cases. I did not see many use-cases to persist values after returning from the handler, so this is an interesting topic.
from fiber.
It is true that it is possible to reproduce the same behavior in Fasthttp, but in Fasthttp it is more forgivable since a) it is clearly documented and b) there is no implicit contract implied in returning a []byte
saying that it won't change under your feet.
It would seem to me that returning a string
constitutes an implicit contract that it will follow string
conventions such as being immutable.
from fiber.
I'm closing this issue because it will be addressed in v1.8.0, feel free to re-open!
from fiber.
I wish the strings returned from the context were wrapped in a new unsafestring struct so when you wrote the code you are forced to call getUnsafeString() or something so it's obvious what you're doing. That way I would pass around unsafestring into functions so I know the string is mutable! All the other go docs say strings are immutable.
from fiber.
Related Issues (20)
- ๐ [Proposal]: Improving route matching and url parsing performance with Ada Url HOT 7
- Improve Error Handling in CSRF Middleware Storage
- ๐ค [Question]: v3 when ready for production HOT 1
- ๐ [Bug]: Unclear "json: invalid use of ,string struct tag, trying to unmarshal unquoted value into uint64" HOT 9
- ๐ค [Question]: Cache Next is not called when KeyGenerator is Defined HOT 6
- ๐ [Bug]: v3 Flash Message with redirect is not working HOT 3
- ๐ [Proposal]: Upgrade fiber.NewError() for error handle HOT 4
- ๐ [Proposal]: Reduce memory usage for "prefork" mode of the master process HOT 2
- ๐งน [Maintenance]: Add Parallel Benchmarks
- ๐ค [Question]: zero allocation - why is this any different from how Chi or others behave? Can you document an example of what you mean? HOT 8
- ๐ค [Question]: FX with Fiber graceful shutdown Failed to stop cleanly: context deadline exceeded HOT 15
- ๐ค [Question]: whats the session id injection issue in github report HOT 4
- ๐ [Bug]: Mutex issues with Idempotency middleware
- ๐ [Bug]: Logger module causes OOM with ${bytesSent} and ${bytesReceived} HOT 10
- ๐ค [Question]: limiter supports dynamic setting of โMaxโ parameter HOT 8
- ๐ [Proposal]: Add StartupProbe support to healthcheck Middleware HOT 6
- [Question]: Can't debug in Goland in Routes HOT 2
- ๐ [Bug]: cache middleware: runtime error: index out of range [0] with length 0 HOT 15
- ๐ [Proposal]: Get session by its ID HOT 1
- ๐ [Proposal]: Support for Application State Management HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fiber.