Code Monkey home page Code Monkey logo

Comments (11)

Fenny avatar Fenny commented on May 1, 2024 3

@1995parham, thanks for submitting your issue.

Fiber is really flexible, you could create your own error handling logic.
The status code defaults to 200 unless changed, you can remove that.

In Fiber v1.5.0 you can pass errors in the Next method.

package main

import "github.com/gofiber/fiber"

func main() {
  app := fiber.New()
  app.Post("/api/register", func (c *fiber.Ctx) {
    if err := c.JSON(&User); err != nil {
      c.Next(err)
    }
  })
  app.Get("/api/user", func (c *fiber.Ctx) {
    if err := c.JSON(&User); err != nil {
      c.Next(err)
    }
  })
  app.Put("/api/update", func (c *fiber.Ctx) {
    if err := c.JSON(&User); err != nil {
      c.Next(err)
    }
  })
  app.Use("/api", func(c *fiber.Ctx) {
    c.Set("Content-Type", "application/json")
    c.Status(500).Send(c.Error())
  })
  app.Listen(1337)
}

We are working on a better way to handle global errors.
Passing the err into c.Next(err) would be nice.
So you can retrieve the error from the Ctx later on with c.Error() for example.

PS: We added Next(err) & app.Recover(handler) & c.Error() #128

from fiber.

Fenny avatar Fenny commented on May 1, 2024 2

@1995parham, PR's are always welcome ๐Ÿ‘
I have time to work on this in the afternoon โ˜•

from fiber.

Fenny avatar Fenny commented on May 1, 2024 1

@1995parham 'v1.5.0' is released, docs coming soon.

https://fiber.wiki/application#recover
https://fiber.wiki/context#error
https://fiber.wiki/context#next

from fiber.

welcome avatar welcome commented on May 1, 2024

Thanks for opening your first issue here! ๐ŸŽ‰ Be sure to follow the issue template!

from fiber.

koddr avatar koddr commented on May 1, 2024

@1995parham thx for issue.

We're working around easy way to error handling right now on Fiber. Stay tuned! ๐Ÿ˜‰

from fiber.

1995parham avatar 1995parham commented on May 1, 2024

@koddr Thanks for your response ๐Ÿ™Œ I will wait.

from fiber.

1995parham avatar 1995parham commented on May 1, 2024

@Fenny I agree with your solution, we can return an error from the handler. If you want, I can create a PR for it.

from fiber.

1995parham avatar 1995parham commented on May 1, 2024

I will create PR so we can work on it ๐Ÿ™Œ

from fiber.

Fenny avatar Fenny commented on May 1, 2024

@1995parham, me and @koddr are actually discussing some kind of recover feature.
This has nothing to do with the c.Next(err), but we would like to hear your thoughts on this.

package main

import (
	"./fiber"
)

func main() {
  app := fiber.New()
  
  app.Get("/", func(c *fiber.Ctx) {
    panic("I panic")
  })
  
  // app.Panic, app.Error // not sure yet
  app.Recover(func(c *fiber.Ctx) {
    fmt.Println(c.Error())  // => "I panic"
    c.SendStatus(500)      // => 500 "Internal Server Error"
  })
  
  app.Listen(3000)
}

from fiber.

1995parham avatar 1995parham commented on May 1, 2024

@Fenny I think to recover from panic in handlers is an excellent feature, and it would be useful in long-running applications. The proposed syntax is simple and useful.

from fiber.

1995parham avatar 1995parham commented on May 1, 2024

@Fenny, sorry for bothering you again. I have checked the new API, and it was good. But is there any way to return an error from the handler, and it automatically passed to the Next method? Like handlers of echo.

from fiber.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.