the timeout option of the library seem not working, here is a simple example code:

thank you <a class="user-mention notranslate" data-hovercard-type="user" data-hovercar

Timeout not working about terminus HOT 3 CLOSED

godaddy commented on August 28, 2024 1

Timeout not working

from terminus.

Comments (3)

ltagliamonte-dd commented on August 28, 2024

as per doc using beforeShutdown hook i can wait but i don't understand the timeout option at this point

const http = require('http');
const { createTerminus } = require('@godaddy/terminus');

function onSignal () {
  console.log('server is starting cleanup');
}

function beforeShutdown () {
  console.log('waiting');
  return new Promise(resolve => {
    setTimeout(resolve, 30000)
  })
}

function onShutdown () {
  console.log('cleanup finished, server is shutting down');
}

const server = http.createServer((request, response) => {
  response.end(
    `<html>
      <body>
        <h1>Hello, World!</h1>
       </body>
     </html>`
   );
})

const options = {
  timeout: 30000,
  onSignal: onSignal,                       
  onShutdown: onShutdown,
  beforeShutdown: beforeShutdown          
};

createTerminus(server,options);

server.listen(8080);

from terminus.

MichaelSitter commented on August 28, 2024

I forked the repo to do a little experimentation with the timeout handling. afaik timeout does work, I don't think your test is exercising the feature correctly b/c you aren't creating any connections before stopping the server. It might be helpful if there was a test case to verify timeout is respected. You can see my findings here:
MichaelSitter#1

from terminus.

ltagliamonte-dd commented on August 28, 2024

thank you @MichaelSitter I confirm that with requests flowing the following snippet works:

const http = require('http');
const { createTerminus } = require('@godaddy/terminus');

function onSignal () {
  console.log('server is starting cleanup');
}

function beforeShutdown () {
  console.log('waiting for k8s environment to completely drain this service');
  return new Promise(resolve => {
    setTimeout(resolve, 10000)
  })
}

function onShutdown () {
  console.log('cleanup finished, server is shutting down');
}

const server = http.createServer(
  (req, res) => {
    setTimeout(() => {
      res.end('hello')
    }, 5000)
  })

const options = {
  timeout: 10000,
  onSignal: onSignal,                       
  onShutdown: onShutdown,
  beforeShutdown: beforeShutdown       
};

createTerminus(server,options);

server.listen(8080);

from terminus.

Recommend Projects