Comments (8)
https://build.gocd.org also uses this plugin so if I remember I can check for our use case during the next brownout on the 8th as well (assuming the API isn't fixed by then!). Looks like we use roughly the same (simple) config as yours.
from github-oauth-authorization-plugin.
Hi there - are you able to help report
- any stacktraces from the plugin logs to show which GoCD functionality was/is affected
- confirm the version of the plugin you are using
- confirm the configuration you are using (redacted if necessary, for the Authorization and the Roles) that should be able to replicate this
This information will make it easier to test from GoCD perspective, even if we are dependent on a change in the API library. Looks like maybe just the below, but would be good to confirm
from github-oauth-authorization-plugin.
hi @chadlwilson
Right now I won't be able to replicate because the brownout from Github only lasted for 12h starting on 2pm UTC yesterday.
- any stacktraces from the plugin logs to show which GoCD functionality was/is affected
There's no errors or stack traces (but I was running with no debug) but what happened was that users were not assigned to their correspondent roles in their team.
What I saw in the logs before the brownout was this:
[MembershipChecker] User `<redacted>` is a member of `<redacted>` organization.
2022-03-01 12:07:22,743 INFO [qtp1382469079-25] GitHubPlugin:72 - [Authenticate] User `<redacted>` authenticated successfully.
2022-03-01 12:07:23,440 INFO [qtp1382469079-25] GitHubPlugin:72 - [MembershipChecker] User `<redacted>` is a member of `developers` team.
And during the brownout:
2022-03-01 15:41:22,338 INFO [qtp1382469079-26] GitHubPlugin:72 - [MembershipChecker] User `<redacted>` is a member of `<redacted>` organization.
2022-03-01 15:41:22,344 INFO [qtp1382469079-26] GitHubPlugin:72 - [Authenticate] User `<redacted>` authenticated successfully.
- confirm the version of the plugin you are using
I'm using the latest version in the releases page (version 3.2.0-135
).
- confirm the configuration you are using (redacted if necessary, for the Authorization and the Roles) that should be able to replicate this
Just configured the specific team for the role to apply like in this screenshot (organization is redacted):
Yup, it also seems to me that this plugin is just dependent from a change in the API library as well.
Thanks for helping out.
from github-oauth-authorization-plugin.
Right, ok thanks, that's helpful!
Perhaps no logs because it's only the team.hasMember
check that is failing. The way that code is written inside the API I think it just catches all exceptions and assumes false regardless of cause.
from github-oauth-authorization-plugin.
See v3.3.0-146 - new API version seems to work fine.
from github-oauth-authorization-plugin.
https://github.blog/changelog/2022-03-04-paused-sunset-of-deprecated-teams-api-endpoints/ FWIW. Sigh :-)
from github-oauth-authorization-plugin.
@chadlwilson oh well... Since then I've updated the plugin and it seems to be working alright.
Thanks for the heads up!
BTW what would be the best option to contact you directly with some quick questions regarding GoCD?
from github-oauth-authorization-plugin.
Feel free to use the Google Groups at https://groups.google.com/forum/#!forum/go-cd or GitHub discussions at https://github.com/gocd/gocd/discussions if it's general questions potentially of relevance to others.
from github-oauth-authorization-plugin.
Related Issues (19)
- 404 using callback URL HOT 2
- GitHub Enterprise integration broken HOT 4
- Blocks entire GoCD server when Github is down/slow HOT 3
- Instructions to configure plugin via automation HOT 1
- Instructions on enable plugin debug HOT 2
- Release 3.3.0-146 possibly affected by CVE-2020-36518 HOT 3
- Request go.plugin-settings.get-configuration is not supported by plugin HOT 1
- Once install the plugin, doesn't show GitHub login page HOT 3
- Plugin styling is coupled to GoCD server HOT 1
- Login page redirects to github.com when configured for GitHub Enterprise HOT 1
- The plugin doesn't works on authentification HOT 7
- Update installation guide for plugin HOT 3
- When are changed emails synchronized into gocd? HOT 5
- It should choose the primary email, not the first one HOT 2
- Document how to use plain values in cruise-config.xml HOT 2
- Redirected with incorrect `client_id` resulting in GitHub 404 error page HOT 5
- Support user search functionality in keeping it compatible with github.oauth.login HOT 2
- Deprecated Github Auth Mechanism HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-oauth-authorization-plugin.