Comments (2)
- 現在、Tokens = []*Token で、添え字アクセスしつつ、Next/Prevを使うことをしてますが、これってNext/Prevだけでlinked listを作ればよくないですか?
token.Tokens
は、 Lexer
から返してあげた tokens
を iteration するときに for range
を使わせてあげたいっていうところからきてまして、内部で Next
, Prev
をもってるのは実装上の都合だったので、公開している I/F を変えない範囲で ( Parser の内部処理など ) は変更しても良いかなと思っています。
ただ、 Next
, Prev
を利用するようにすると、 token.Tokens
に対して好きに token を追加削除した後に Parser に渡すとおかしくなってしまうので、このあたりをケアしてあげるような API を追加 ( Tokens.Insert
や Tokens.Remove
を足すとか ) する必要があるなと思っていました。
- reserved tokensは一回作って使い回していますが、これって複数のgoroutineでアクセスするときとか、filteredTokensとかを作る時にNext/Prevとかの値が上書きされておかしなことになりませんか?reservedも動的に生成するようにしていいですか?
あれ、 reserved
なやつは、 token 生成用の function map で管理しているので、都度生成するようになっていると思いますが、そういうことではなくでしょうか
from go-yaml.
2は 失礼しました!読み間違えてました!
from go-yaml.
Related Issues (20)
- segfault when using the return of a path which combines IndexAll and Child
- `Unmarshal` will `panic` on malformed octets
- Decoder overrides defaults with null values
- JSON is not marshalled with escaped content
- Simple quote encoded with two simple quote if ] present HOT 1
- req: better docs around InterfaceMarshaler/InterfaceUnmarshaler
- replacing values with a multi-line string value provides broken yaml format. HOT 10
- Add InterfaceCustomUnmarshaler
- Increased memory consumption when serializing long slices.
- Support custom unmarshalling for mapping keys
- DisallowDuplicateKey doesn't fail if a child has duplicate keys
- Tokenizer does not handle double quoted strings well
- Small float values can't be decoded after an unmarshal-marshal round trip
- Unmarshal drops lines and does not return error
- Does not remove left side CRLF when it appears after a space character
- Security issue: Parsing malicious or large YAML documents can consume excessive amounts of CPU or memory.
- Stack overflow issue
- Run yaml-test-suite on CI
- Fuzz `yaml.Unmarshal`
- Lexer and Parser information for creating intelisense support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-yaml.