Cancelling unmarshalling about gocsv HOT 6 CLOSED

Closing the reader does produce an error and stop the marshalling process. My problem was with my surrounding code, forgetting to close the channel. Only if the marshalling completes successfully is the channel closed.

from gocsv.

Are you using https://godoc.org/github.com/gocarina/gocsv#UnmarshalToChan ?

from gocsv.

Yes I am using this method.
I have a few downstream consumers that need the input channel to be closed
before they can exit.
On 2 Mar 2016 3:59 p.m., "Vincent Nëel" [email protected] wrote:

Are you using https://godoc.org/github.com/gocarina/gocsv#UnmarshalToChan
?

—
Reply to this email directly or view it on GitHub
#24 (comment).

from gocsv.

I don't see any clean way to do that. You could close the channel, but it would panic because you can't send values to a closed channel.

I don't know of any easy method to check if a channel is closed without trying to read from it.

If you have an idea to how we could do that without changing the API, i would be happy to hear it. If not, the only solution would be to write another function which take two channels, one which will be the output of the csv read and the other one to cancel the unmarshalling.

from gocsv.

Is there any way to detect that the reader is close and nothing left to read?
If not then I would agree adding a cancelation channel would be to natural route forward.

Would you accept a pull request adding this functionality using this approach?

from gocsv.

Yes of course :) I will look into why does closing the reader does not stop the reading, looks suspicious to me.

from gocsv.