Comments (4)
I think serve that in backend is a good idea, and I like to avoid crapy JavaScript as much as possible.
Yeah, both ways can coexist, but on my mind, if I'm using the JS interface, I'd prefer everything to load that way. Helps making a PWA for mobile devices easier to develop too. But again, just random thoughts on my head.
In this particular case, since we open a new tab for article content, a "go back" equals to a "window.close()
".
from shiori.
@fmartingr somehow I agree. We can do both and user can be select between them in settings.
if you don't have a problem with that (make codebase bigger for this kind of setting) I can do that.
I think open in current tab is better option. User can be always open in new tab.
from shiori.
I just got used to the fact that the article opens in a new tab and just close it when I want to go back to the main Shiori interface. I keep thinking that maybe we should add the readable to the main javascript interface instead of serve that in the backend, but it's some discussion I want to have once I finish the new API (#497). I should sit down and elaborate a proper roadmap too.
from shiori.
I think serve that in backend is a good idea, and I like to avoid crapy JavaScript as much as possible.
Personally, I prefer to keep shiori keep fast as possible. I am tired of all heavy slow project out there.
About roadmap, I like that idea. I suggest review KOReader project. How it is good to organize, maybe you can find good point there.
from shiori.
Related Issues (20)
- Container image tag "latest" is not updated v1.6.0 HOT 2
- Investigate mysql database url using password with special characters not working HOT 5
- Cannot rename tags in v1.6.0
- Some API calls do not respect root path HOT 6
- Improve search behavior
- Apache reverse proxy does not work for me HOT 25
- Shiori auto increasment not work currectly on sqlite database HOT 1
- Search API Fails to Return Results for Multi-Keyword Queries HOT 4
- Can't use anymore after last upgrade HOT 2
- Shiori can't migrate from 1.6.3 to last commit in master, if you use Postgres or Mariadb HOT 4
- Unify datetime manipulation for the multiple database engines
- Home button should clear search query
- PUT request to /api/v1/bookmarks/cache takes too long HOT 2
- Allow PDF file archives
- "View Original" link in the archive view references the same page HOT 1
- Frontend refactor to Vue3 HOT 1
- Some asset take so much time to load when became behind revece proxy HOT 2
- Update the usage docs HOT 1
- Allow running arbitrary actions over bookmarks HOT 2
- One line description of the bug HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shiori.