Comments (5)
A user who wants to reload could just use "F5" - unless I misunderstand what that link does
the reload button doesn't perform a page reload. It updates the bookmark results via ajax
from shiori.
Ahh I misunderstood its purpose then! But regardless it would be nice to see a tag list/cloud page.
Looking at the code I think this will be pretty simple. I will submit a pull-request later in the day.
Edit: This turned out to be harder than I thought. I updated sqlite.go + database.go to add a new function:
// FetchTags returns all the unique tags, and their use-count
FetchTags() (map[string]int, error)
Then I updated the server to use that:
router.GET("/tags", serveTagsPage)
However that's probably not the right way to go. I suspect instead I should be using an AJAX call beneath /api/tags and that is beyond me because fileb0x fails to regenerate my assets ("Token too long").
I'll leave this open as a wishlist, and hope it is accepted in the future.
:)
from shiori.
Looks like this has been implemented in :
I'll close.
from shiori.
@skx I've merged it in eee3dc7. Could you check it out ?
from shiori.
Looks great, I'm happy to close this.
I'm sure I'm not alone in appreciating how responsive you've been to issues and pull-requests. :)
from shiori.
Related Issues (20)
- Search error: failed to fetch count: pq: syntax error at or near "AGAINST" (500) HOT 3
- First start creates an empty database with no tables HOT 11
- The saved page takes up an unreasonably large amount of space HOT 2
- Error with docker image HOT 2
- Error when searching for a keyword that does not exist in the database HOT 1
- Images missing HOT 2
- FR: Disable archive HOT 2
- Unable to import from Safari html file HOT 2
- [Feature request] Improve tag suggestions
- Using dash in search field doesn't work and gives error
- Cannot add bookmarks using shiori git HOT 4
- The application does not remove the thumbnail file from the FS if it is removed in the original article HOT 3
- failed to fetch count: pq: syntax error at or near "AGAINST" (500) HOT 1
- Use font with wide scripts support HOT 1
- Error running migration: SQL logic error: no such module: fts4 (1) in line 0: ALTER TABLE bookmark HOT 2
- Properly integrate a logging solution HOT 2
- Docker image cannot be used with SQLite in a mounted volume HOT 21
- Table bookmark_content_data is not cleared on "shiori delete" HOT 2
- Clicking on tag shows no bookmarks in search
- I can't export all my bookmarks. HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shiori.