Code Monkey home page Code Monkey logo

Comments (3)

a-kr avatar a-kr commented on June 24, 2024

@vmihailenco @LK4D4 At the very least the failing build should be fixed somehow, however I'm not sure exactly which behavior you intended to implement, and therefore I'm hesitant to write any fixes myself.

from pg.

vmihailenco avatar vmihailenco commented on June 24, 2024

Thanks for review. In the future I will keep PR open to let you review the code.

For example, what is the difference between lines 191 and 192, if in both cases dst is of type *bool?

boolptr is nil pointer. So line 192 tests decoding NULL into nil pointer. wantnil: true means that the result should be nil pointer.

The intent of this code is not clear:

Let me try to fix it.

from pg.

a-kr avatar a-kr commented on June 24, 2024

In the future I will keep PR open to let you review the code.

I don't think this will be necessary in general, but please ping me in the comments if you need a review any time.

Thanks for fixing this.

from pg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.