Code Monkey home page Code Monkey logo

Comments (5)

ChrisHines avatar ChrisHines commented on May 19, 2024

@tonyhb I am a heavy user and one of the maintainers of log15, so I am familiar with the feature you linked to. Honestly, I've never felt the need to use that feature. I would like to hear more about your experience to get some perspective on the benefits of this feature.

from kit.

tonyhb avatar tonyhb commented on May 19, 2024

@ChrisHines for me it's only the structure and ease of readability of using map-like arguments instead of varargs — though that's about the only reason. It's why I'm a huge fan of Logrus' log.Fields{...}. Completely understand that personal preference isn't a valid reason for implementation, though.

from kit.

ChrisHines avatar ChrisHines commented on May 19, 2024

@tonyhb I am interested to see an example of how you use Logrus' log.Fields{...} or log15.Ctx.

One of the early proposals for the Go kit log API had a Logrus style API. I argued against that style here: #21 (comment).

from kit.

peterbourgon avatar peterbourgon commented on May 19, 2024

I do see the value in having typed arguments to Log, especially (perhaps only) for applications using log-structured data, rather than simple application logs. But I'd expect all of those use cases would have application-specific types, and they'd all boil down to wrappers around the existing API anyway, so I'm not sure how much value an explicit Fields type would provide.

from kit.

ChrisHines avatar ChrisHines commented on May 19, 2024

Closing this as out of scope for the core log package.

from kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.