Comments (5)
quasilyte
commented on May 25, 2024
You can start with a simplest case: fix function result types.
This way, you can concentrate on parenthesis elimination instead of type expression seeking.
Then you can expand the scope to more type expressions.
from go-critic.
quasilyte
commented on May 25, 2024
There is also (*a)[i] where a is an array (not a slice).
from go-critic.
quasilyte
commented on May 25, 2024
Do we need astutil?
https://github.com/golang/tools/blob/master/go/ast/astutil/util.go#L6
from go-critic.
fexolm
commented on May 25, 2024
Function output parameters check is done in #22.
Variable type check is done in #31
from go-critic.
fexolm
commented on May 25, 2024
Checks 2 and 5 moved to #14.
from go-critic.
Related Issues (20)
- go1.21: load rules: parse rules file: typechecker error: ...: could not import HOT 5
- sloppyTestFuncName incorrectly identifies helper function HOT 2
- new check: find identical condition
- bug: `rangeValCopy` still panics on code with generics HOT 3
- new check: I/O find close twice HOT 1
- go1.21: load embedded ruleguard rules: rules/rules.go:13: can't load fmt HOT 14
- unlambda: false positive HOT 1
- timeCmpSimplify: false positive, not before is unequal to after HOT 2
- dynamicFmtString: use rather fix errors.New than fmt.Errorf("%s" HOT 2
- new check: detect unnecessary gomock controller Finish call HOT 1
- `gocritic check` panics with invalid memory address or nil pointer dereference HOT 4
- emptyStringTest: handle len(s) > 0
- Please elaborate docs for `hugeParam`: Why 80 as default? HOT 4
- Disabling a non-existant check should not be a fatal error HOT 4
- deferUnlambda: False positive for mutated variable HOT 2
- Upgrade to golang 1.22 HOT 1
- explicitly enabled check is disabled by tag HOT 2
- feature request: able to disable `hugeParam` for some structs via `.golangci.yaml` HOT 2
- check/importShadow: panic due to concurrent access of `PkgObjects` map HOT 15
- regexpSimplify gives an incorrect simplification for `(foo|)`.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-critic.