Comments (6)
I believe @ludweeg is looking into it.
from go-critic.
@quasilyte, possibly duplicate of #72?
from go-critic.
Not exactly. Referenced issue turns range loops into other range loops.
This is about C-style for loops.
from go-critic.
We can handle it in one checker or in different checkers, if there is close to 0 shared code.
Hard to tell without implementation.
(Note that range
and simple for are different AST nodes.)
from go-critic.
Ok, clear now.
from go-critic.
Different checkers, pretty please.
from go-critic.
Related Issues (20)
- Compilation error under Go 1.20 HOT 3
- Non zero exit code in case of issues
- Ignore generated files or specific directory? HOT 2
- New release? HOT 6
- How to speed it up HOT 18
- redundantSprint false positive with err.Error() when err is nil HOT 1
- new check: mismatching format HOT 1
- httpNoBody: also warn on using "nil" instead of "http.NoBody" on (net/http/httptest).NewRequest HOT 3
- go1.21: load rules: parse rules file: typechecker error: ...: could not import HOT 5
- sloppyTestFuncName incorrectly identifies helper function HOT 2
- new check: find identical condition
- bug: `rangeValCopy` still panics on code with generics HOT 3
- new check: I/O find close twice HOT 1
- go1.21: load embedded ruleguard rules: rules/rules.go:13: can't load fmt HOT 14
- unlambda: false positive HOT 1
- timeCmpSimplify: false positive, not before is unequal to after HOT 2
- dynamicFmtString: use rather fix errors.New than fmt.Errorf("%s" HOT 2
- new check: detect unnecessary gomock controller Finish call HOT 1
- `gocritic check` panics with invalid memory address or nil pointer dereference HOT 4
- emptyStringTest: handle len(s) > 0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-critic.