all: add more github status checks about go-critic HOT 10 CLOSED

@quasilyte, ok, i'll do it.

from go-critic.

You mean including gometalinter into CI checks?

from go-critic.

@quasilyte no. I mean we could find github app, that will run gometalinter on our code.

from go-critic.

Ah, I see.

from go-critic.

There is no github apps with enough checks(or free), so i'll add gometalinter and goreportcard in Travis.

from go-critic.

so i'll add gometalinter and goreportcard in Travis.

@weeellz, that's quite brutal.

I've seen some minor issues like typos in comments like this:

// WarkingKind describes checker warning category.
// Useful for checkers that can find different kinds of issues.
//
// Should be human-readable, not cryptic.
type WarningKind string

Note WarkingKind (typo).

Our build will break if someone will not fix all of them.
Could you fix these places along with CI script changes?

from go-critic.

Just a reminder: everything under testdata should not be linted during CI.
It's checked by gofmt -s -d now, but really shouldn't.

from go-critic.

@quasilyte, i don't quite understand second problem.

from go-critic.

Currently, we have this CI step:

diff -u <(echo -n) <(gofmt -d -s .)

The problem is that it also checks testdata it shouldn't.
And if new checks are added, they should not touch testdata, because it will trigger a lots of warnings which we don't want to fix.

from go-critic.

Done in #28.

from go-critic.