Code Monkey home page Code Monkey logo

Comments (3)

daniel-nichter avatar daniel-nichter commented on September 18, 2024

Thanks for the report. I think the issue is that, in this case, Stop returning nil is misleading because of this block:

    // Nothing to stop if Start hasn't been called, or the proc hasn't started,
    // or it's already done.
    if c.statusChan == nil || !c.started || c.done {
        return nil
    }

If the cmd hasn't started yet, Stop returns nil which gives the impression that it was stopped ok when really it hadn't even started yet. So I don't think there's a race condition per-se, but rather that Stop should return an error, perhaps ErrNotRunning. In that case, caller knows that they need to wait and try again.

from cmd.

davrux avatar davrux commented on September 18, 2024

Yes, i think that would help. So it's easy to come back laster if the function returns ErrNotRunning.

from cmd.

daniel-nichter avatar daniel-nichter commented on September 18, 2024

Well it took a very long time, but finally fixed: #52

Thanks for reporting this!

from cmd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.