Comments (4)
After some digging with the help of Traefik community in traefik/traefik#10195, we've located a regression since the upgrade from aws-sdk-go
v1.39.0 to aws-sdk-go-v2
v1.19.0 introduce in that commit fc47c35
aws-sdk-go
didn't force the user to specify an AWS region on some service. You can find the list of services here: https://github.com/aws/aws-sdk-go/blob/7087ed2d41a8462e40c00a473fa884d79124b660/aws/endpoints/v3model.go#L183-L200
But the new version aws-sdk-go-v2
is much more strict and doesn't allow it.
The fact that we didn't see it coming in the unit tests is because it's a check done in the endpoint Resolver that we mock: https://github.com/aws/aws-sdk-go-v2/blob/57a201c7bb214737f78cf871fbeafaa929bf1d8d/service/route53/internal/endpoints/endpoints.go#L66-L77
from lego.
Hello,
You said:
I would expect to still be able to not provide an AWS region.
and
But the new version aws-sdk-go-v2 is much more strict and doesn't allow it.
We will not revert the migration to the aws-sdk-go-v2, so what is your suggestion?
from lego.
Just reporting the issue, from the outside it's a regression.
Now I understand that there's no much we can do. If we provided a default region directly in Lego like it's done in lightsail, it would create even more breaking change for those using AWS_SDK_LOAD_CONFIG
.
So yes, I agree with you. Can't be fixed.
from lego.
So we agree on the conclusion: it can't be fixed, the region is now a requirement but it depends on the type of credentials used to authenticate.
from lego.
Related Issues (20)
- on armv7I-32 CPU: this CPU has no VFPv3 floating point hardware HOT 3
- renew doesn't take multiple domains HOT 1
- "The HTTP S3 Present should not utilize Object ACL permissions, as they are not recommended."
- acme: error presenting token: alicloud: zone com. not found in AliDNS for ... HOT 2
- oraclecloud is using only default realm OC1 for all requests HOT 7
- Missing and misleading hook environment variables HOT 4
- Add support for Route53 private zones HOT 1
- '--dns exec' show output in real time? HOT 3
- Add SLSA provenance to your releases
- renew-hook does not support quoted parameters HOT 1
- Add Retry-After header value to get renewal info result HOT 3
- DNS request prefer IPv6 only HOT 1
- exoscale: fails when issuing certificate for "*.domain.example" and "domain.example" HOT 14
- Ability to update email using the CLI
- Support for provider: mittwald HOT 6
- azuredns: CLI authentication doesn't respect tenant setting
- DNS certificates with many names: Faster verification HOT 13
- Support hook arguments HOT 3
- Whether you can support manual custom validation of DNS records in golang dependent mode?
- Leftover deprecated update renewal info call
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lego.