Code Monkey home page Code Monkey logo

Comments (7)

dimus avatar dimus commented on July 18, 2024

Hm, Genus (Subgenus) should work according to these tests:

https://github.com/gnames/gnparser/blob/master/testdata/test_data.md#combination-of-two-uninomials


Name: Aaleniella (Danocythere)

Canonical: Aaleniella subgen. Danocythere


Name: Cordia (Adans.) Kuntze sect. Salimori

Canonical: Cordia sect. Salimori


Name: Calathus (Lindrothius) KURNAKOV 1961

Canonical: Calathus subgen. Lindrothius


Can you add examples that show your cases?

from gnparser.

dimus avatar dimus commented on July 18, 2024

Can you please show examples for worries about "Author in Author, Year"

from gnparser.

dimus avatar dimus commented on July 18, 2024

Looks like I need to add "dem" as an author word: Von dem Busch. Ill check if dem ever happens as a specific epithet.

from gnparser.

Mesibov avatar Mesibov commented on July 18, 2024

@dimus, sorry, I wasn't paying attention to this issue. The "Genus (Subgenus)" and "Author in Author, Year" cases I was thinking of can be found in in https://github.com/gnames/gnames/files/12587991/regex_OK_gnparser_no.txt. Both forms throw up a quality rating of 2.

Please also note that in "Eutrochatella babei (Arango y Molina, 1876)", the "y" is part of the author's surname, so the quality 2 indicator "Spanish 'y' is used instead of '&'" does not apply.

from gnparser.

dimus avatar dimus commented on July 18, 2024

Thank you @Mesibov for explanation. I do think that y should decrease the quality, because there are many other languages that people can use for the and word, and doing so will create a mess. So I decided to limit and words to and and &. I personally would prefer et though :)

I am not sure what to do if y is a part of the Author name, I guess I do need to put exceptions and hardcode such authors into gnparser.

Added #251

from gnparser.

dimus avatar dimus commented on July 18, 2024

In case of Genus (Subgenus) and Author in Author the quality is decreased after discussion with Paddy Patterson about these two issues. For botanical names 'Author in Author' is actually valid, so I am on the fence about it. For Genus (Subgenus) I can double check with ICZN folks.

from gnparser.

dimus avatar dimus commented on July 18, 2024

I did try to address most of the problems in v1.7.5

from gnparser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.