Masking artifacts (small white squares) when using improved segmented mask about sd-webui-faceswaplab HOT 7 CLOSED

Yes, I know that one. It's not technically a bug. It's when improved mask is used with no Upscaler is selected in post-processing (in faces unit). You need to either disable improved mask or add an upscaler (Lanczos if you want speed, LDSR if you want quality, or see configuration below).

See this PR : #35 where i describe the same problem. I added a warning in the console to say that it wasn't a good idea to use the improved mask without using an upscaler. You should at least use Lanczos.

 2023-08-07 15:02:56,469 - FaceSwapLab - WARNING - Please note that improved mask does not work well without upscaling. Set upscaling to Lanczos at least if you want speed and want to use improved mask.

I'm talking about the post-processing tuning in the faces. Not global post-processing.

from sd-webui-faceswaplab.

See here #25 recommanded settings.

from sd-webui-faceswaplab.

Yes it's my fault, i commited too fast. And i was also surprised by the result. The improved mask was set to True by default in the settings (False if no settings were sets). You must have changed the settings in the meantime, which activated the improved mask by default.

I always automatically test the software before committing. But Gradio is a pain to test and there are no automated tests yet. The problem with this kind of little thing is that when I test, my test program uses my configuration. I'd have to do more exhaustive tests, but that would be a real pain.

from sd-webui-faceswaplab.

I was able to get everything working perfectly again (even better with your suggestions). Thanks again!

Also, I forgot to mention... this is an absolutely amazing extension with a ton of great tools/features. Fantastic job, I really appreciate your hard work!

from sd-webui-faceswaplab.

Before Swap:

After:

from sd-webui-faceswaplab.

Ah, did the default setting change recently that would enabled the improved mask or deselected a default upscaler?

I fairly certain I've been using the same workflow for the last few days and this configuration problem just started for me.

from sd-webui-faceswaplab.

No worries, glad to hear it's just configuration related. Thanks for the quick feedback and info! Feel free to delete/close this thread.

from sd-webui-faceswaplab.