Comments (4)
Hi @steve-gray
I fully understand the use case here - a lot of applications using mgo/MongoDB also expose data via JSON, and I bet there's been more than a few lost hours to typos between the bson
and json
tags! Totally happy to accept this as a PR.
My only comments would be to defer performing the JSON tag search till after determining there's no BSON tag (avoids searching for an unused JSON tag) and to include the docs for useJSONTagFallback
in SetJSONFallback()
as thats all that will show in godoc - minor things!
Having this behind a feature flag was a pleasant surprise, you clearly take backwards compatibility to heart - thanks for taking the time to contribute.
Dom
from mgo.
Closing as #91 will fix imminently.
from mgo.
@domodwyer - Any timeline on merge to mainline? I'm looking to leverage this functionality and I'm struggling with having type incompatibility between code that references my custom fork and 3rd party code that references the globalsign instance on a project.
from mgo.
Hi @steve-gray
Really sorry about the delay - the infrastructure I use to test mgo was in use for other things - I'll try and arrange to cut a release tomorrow.
Dom
from mgo.
Related Issues (20)
- Query blocks with ChangeStream HOT 2
- Upsert doesn't work well with query where value is []byte format
- Expose dialInfo through a getter?
- High concurrency session copy does not release the connection and poolLimit is invalid
- Request: BSON stabilize ordering of map keys (instead of GoLang's random ordering) HOT 1
- Unwanted allocs in mgo
- Auto type assertion not working when fetching data
- Clean actions attribute of Bulk struct
- time.Parse HOT 2
- can any one tell me how to use $near to calculate lat,lng distance
- MongoDB index not being used when querying through mgo on mongoDB views
- }
- DropDatabase returns not master when seesion mode is Secondary
- mgo: FindAndModify create too many sockets
- error="SASL support not enabled during build (-tags sasl)" HOT 8
- Daemontools
- Panic With ObjectIdHex(s string)
- current
- BSON unmarshal unable to parse $date
- error="no reachable servers" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mgo.