Code Monkey home page Code Monkey logo

Comments (9)

danielcrisp avatar danielcrisp commented on June 24, 2024 2

It's an XHR request from the browser, but it's the response body that is huge - not the request body.

Let me see if I can knock up a quick repo...

from home.

danielcrisp avatar danielcrisp commented on June 24, 2024 2

Ok, try this: https://github.com/danielcrisp/glimpse-example

from home.

mike-kaufman avatar mike-kaufman commented on June 24, 2024 1

Thanks @danielcrisp - the repro you put up was perfect. The issue here is those setting values were never getting communicated to our "Browser Agent" - the piece of code that runs in your browser and gathers diagnostic data for what's happening client side. I've got a fix up to address this. We should have this release next week.

Once the fix is available, you'll need to update your repro since you're injecting the browser agent by hand. You'd need some code like the following, note the config-settings attribute and the values there. They would need to correspond to the values you're using for "server.max.json.body.size" and "inspector.http.body.capture.maxsize". Of course, if you're not hand-injecting the browser agent script, then this should "just work".

    <script src="http://localhost:3000/glimpse/agent/agent.js"
        id="__glimpse_browser_agent"
        data-message-ingress-template="http://localhost:3000/glimpse/message-ingress/"
        config-settings="{&quot;server.max.json.body.size&quot;:20000,&quot;inspector.http.body.capture.maxsize&quot;:10000}">
    </script>

Let us know if you have any ?s or feedback.

Thanks,

Mike

from home.

mike-kaufman avatar mike-kaufman commented on June 24, 2024

Thanks for opening the issue @danielcrisp. Are you running mongodb? With release 0.22.11 we started capturing data passed to mongo DB (documents on insert commands, queries objects and update objects). We have a bug where we're not truncating captured data & this can result in the errors you describe. We should have a fix out in a few weeks time.

from home.

danielcrisp avatar danielcrisp commented on June 24, 2024

Hi @mike-kaufman, nope I'm not using mongodb - it's just a simple Express app that mocks our API endpoints with fake JSON data.

I'm familiar with the huge amounts of data that mongodb can expose for a single document though. Is the size the problem? Does your fix address the size for all requests or is it only specific to mongod?

from home.

mike-kaufman avatar mike-kaufman commented on June 24, 2024

interesting. What type of request is generating a body with size of 396989 bytes? Is this an XHR or fetch request from browser? Or from a node's HttpClient?

Does your fix address the size for all requests or is it only specific to mongod?

We don't have the fix yet, we just know this is a problem with the mongodb messages we're generating, and we're planning to fix it.

from home.

mike-kaufman avatar mike-kaufman commented on June 24, 2024

btw - if you have a simple repro case that we can run, that would be most helpful. Understand if your code isn't public or your environment is too hard to replicate.

from home.

danielcrisp avatar danielcrisp commented on June 24, 2024

Great! Sounds good - when the fix is released I'll update the repo to give it a go.

Thanks Mike,

Dan

from home.

mike-kaufman avatar mike-kaufman commented on June 24, 2024

ok, version 0.22.15 is now up on npm, and it has the fix for this. Please let us know if you have any other problems or feedback.

from home.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.