Binder plugin overwrites my binder with GlimpseDefaultModelBinder using NInject about glimpse HOT 4 CLOSED

Good catch llusetti,

I'll make sure we update this for the next release, it should either A) wrap
the DefaultModelBinder, or B) not mess with your configuration if we can't
wrap.

Please let us know if you run into any other issues - we know we don't have
too many users doing their own implementations of some of the more
"internal" parts of MVC, so your feedback is much appreciated.

Thanks,
Nik

On Tue, Apr 19, 2011 at 8:17 AM, llusetti <
[email protected]>wrote:

Hi, I've started using Glimpse today so maybe I'm wrong about this or
occurs only in my configuration.

I user NInject in my MVC application and my MvcApplication class extends
Ninject.Web.Mvc.NinjectHttpApplication. I override OnApplicationStarted and
set ModelBinders.Binders.DefaultBinder to my custom implementation.

I've noticed that biding was broken after adding Glimpse to my project. I
looked inside Glimpse source code and found that in the Binders plugin the
DefaultBinder gets replaced if it's not a GlimpseDefaultModelBinder

if (!(ModelBinders.Binders.DefaultBinder is GlimpseDefaultModelBinder))
   ModelBinders.Binders.DefaultBinder = new GlimpseDefaultModelBinder();

Is this the intended behavior or should it be replaced by a wrapper ?

if (!(ModelBinders.Binders.DefaultBinder is GlimpseDefaultModelBinder))
{
   if (ModelBinders.Binders.DefaultBinder == null)
       ModelBinders.Binders.DefaultBinder = new
GlimpseDefaultModelBinder();
   else
       ModelBinders.Binders.DefaultBinder = new
GlimpseModelBinder(ModelBinders.Binders.DefaultBinder);
}

Reply to this email directly or view it on GitHub:
#19

from glimpse.

I'm really happy to contribute in some way to this great tool. For me it was love at first sight!

Thanks
Luca Lusetti

from glimpse.

@llusetti thanks for working with us to help sort out these issues and thanks for the positive feedback - keep an eye out for the next release

from glimpse.

@llusetti we know about the support for type of scenario with Glimpse not being ideal. At the moment we are making changes that will help with being able to support it (i.e. we are working with DynamicProxy to be able to do some wrapping which should be able to facilitate this). Keep an eye out on the next release.

from glimpse.