change how observer mode works about glest-source HOT 6 CLOSED

not sure yet how to fix it, but this is the current problem:

Everything could be shifted down, but this would make the comment box even smaller, which is unideal.
An ideal solution is a scroll for player positions. I'll have a look to see if that's possible.

from glest-source.

I can't believe I really did this! Or at least.. that I was able to do it so quickly. I've been picking at it for a few days.

You can see in the screenshot below that I need to move some text on the setup menu around, but basically as far as testing, I was able to:

• start a server
• checkbox -> allow observers
• connect with a 2nd client ; select slot 5 on a 4 player map and choose "observer" for faction
• start the server and neither server nor client crashed!
• game started and 2nd client was in observer mode, as intended. I quit after a minute. All seems ok initially.

There wasn't much code I had to add or change (though I took the opportunity to update the license header at the top of the source files I edited).

To see the changes, take a look at https://github.com/ZetaGlest/zetaglest-source/pull/14/files

I want to clean up my code changes better though, before I merge in the changes.

from glest-source.

So far so good!

9 slots used on an 8 player map. A game running for ~23 minutes.

@Jammyjamjamman , would you be interested in repositioning the text? You'll see the menu next time to pull the source and load a custom game.

The text can be moved by changing some values here:

https://github.com/ZetaGlest/zetaglest-source/blob/31d91e854416384f07b512aed1ffd8ef3cdbb4ca/source/glest_game/menu/menu_state_custom_game.cpp#L200-L210

Also there are some values in menu_state_connected_game that have to be changed.

If it doesn't interest you to make changes like that, I'll do it soon.

from glest-source.

I'll make a note on the ticket for others...

There's scrollbar code being used in https://github.com/ZetaGlest/zetaglest-source/blob/464860aa023e4089f4c6f108e019d66d60052581/source/glest_game/menu/menu_state_masterserver.cpp#L75

from glest-source.

Unfortunately I didn't get this patch done in only 1 commit.

For reference, here were the first 2 parts:

42541ca
31d91e8

from glest-source.

Most recent commit that adds to this patch:

af3ff60

from glest-source.