Comments (4)
Hey @mrkutly ! Thanks for your help. I think we should avoid having the query in the path at all
from http.
I thin this may have been a bug in the gleam_elli
library which was since fixed.
Looks like we are confident everything works here now so we can close this ticket. Thank you for your investigation 💜
from http.
@lpil I would love to take a crack at this one! I am wondering if this should be fixed in the gleam/http/request
module or in the stdlib's gleam/uri
module here?
Or would it be better to prevent the query and fragment from ever ending up in the request.path
at all? As in, handle this in the from_uri
function, which seems to be the only way to get a Request
type.
from http.
Sounds good! @lpil Do you have steps to reproduce the case where you were seeing query strings show up in the Request path
?
Update: this appears to be handled by the erlang uri_string:parse
function here
I tried to recreate locally by making a quick webserver and making requests to:
localhost:3000/path/is/here?query=true#fragment
localhost:3000/path/is/here?query=true
localhost:3000/path/is/here#fragment
Doing request |> path_segments |> io.debug
always printed [<<"path">>,<<"is">>,<<"here">>]
as expected.
from http.
Related Issues (14)
- Add a `get_resp_cookie` HOT 1
- default response body should be bit builder. HOT 2
- Add an origin function. HOT 3
- Patch release including the bug fix for Max-Age HOT 1
- Conflicting `None` definitions HOT 2
- get_req_origin should return Error(Nil) Instead of an option HOT 2
- request.set_header shouldn't lowercase header values HOT 2
- request.new function that takes a URL string as an argument HOT 2
- Multipart form parser
- Scope of this library, stdlib integration HOT 4
- Missing tests
- Documentation example imports gleam/elli HOT 1
- Can't be used with stdlib 0.10.1 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from http.