Code Monkey home page Code Monkey logo

Comments (4)

helloteemo avatar helloteemo commented on August 19, 2024

The built-in auth is complicated. Some authentication information needs to be stored within the system, and persistence needs to be considered

Shouldn't Glance be viewed as an all-around system; as an adhesive between multiple systems, it is more in line with the business positioning?

If it should be used as an adhesive, can an interface be defined to connect to an existing authentication service in the form of an interface to achieve auth

Such as

type AuthConfig struct {
	// RedirectURL is the URL to redirect the user to when they need to log in.
	LoginRedirectURL string
	// IsAuthenticatedURL is the URL to check if the user is authenticated.
	IsAuthenticatedURL string
}

type Auth interface {
	// IsAuthenticated returns true if the user is authenticated.
	IsAuthenticated(macAddress string) (bool, error)
	// JumpToLogin redirects the user to the login page.
	JumpToLogin(macAddress string) error
}

from glance.

flamestro avatar flamestro commented on August 19, 2024

I am not sure if glance needs auth tbh, as most of the information is public anyway.
You could argue that the collection of the given information in one pot makes it kinda data sensitive. But thats up to the maintainers.

Anyways, in the meantime you can use this to get oauth up and running without glance implementing auth:
https://github.com/oauth2-proxy/oauth2-proxy

from glance.

svilenmarkov avatar svilenmarkov commented on August 19, 2024

Hey, thanks for the suggestion!

Unfortunately I don't plan on adding auth for the time being, though you can easily overcome this limitation by using something like Authelia or Authentik.

from glance.

adrian-goe avatar adrian-goe commented on August 19, 2024

A BasicAuth option should be enough right? At least, a first initial option.
I'm not familiar with go. So I can't help here.

from glance.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.