Comments (15)
I judged too fast. Everything works as expected. We should improve the message anyway.
from html-proofer.
More details:
I had expected the directory_index_file
option to fix the "./_build/linux/usage/commands.md: internally linking to ../../remote-access/ssh/, which does not exist" error of https://travis-ci.org/raspberrypi/documentation/builds/33684029 since linux/usage/commands.md
indeed has a link like [SSH (secure shell)](../../remote-access/ssh/)
(which is why my commit-comment was "Attempt to fix one of the Travis build errors")
But I was very surprised that it also fixed the "./_build/configuration/raspi-config.md: internally linking to , which does not exist" errors, which seem to be caused by e.g. <a name="usage"></a>
(configuration/raspi-config.md
contains 19 named anchors, and the "raspi-config.md: internally linking to ," error appears 19 times).
Perhaps adding the directory_index_file option somehow 'masks' the named-anchor bug? (obviously if linux/usage/commands.md
had instead linked directly to ../../remote-access/ssh/README.md
I would never have added that option in the first place!)
from html-proofer.
@lurch The use of the name
attribute for anchors is deprecated. You should use the id
attribute. Can you switch to id
and try again?
from html-proofer.
Unlikely to happen - it's the 'recommended' way of doing it according to https://github.com/raspberrypilearning/creating-resources/blob/master/markdown.md#anchors
They may be 'deprecated' but they're used all over the place on both https://github.com/raspberrypi/documentation and on https://github.com/raspberrypilearning/
You're welcome to raise it as an issue at https://github.com/raspberrypi/documentation/issues but given the amount of documentation and resources that have already been written you'd be unlikely to get very far IMHO.
from html-proofer.
@lurch Thank you for the great report. The placeholder issue should be fixed in #107.
from html-proofer.
That's great to hear :)
Just out of curiosity, did you manage to figure out how / why enabling directory_index_file masked the named-anchor errors?
from html-proofer.
@lurch No, I had no time for deeper analysis.
from html-proofer.
Thanks for fixing the issues so promptly!
Let me know when the next version of html-proofer is released, and I can force a Travis-rebuild of raspberrypi/documentation to check that it still works with the new version :)
from html-proofer.
It's bumped now to 1.3.3.
from html-proofer.
A forced-rebuild of https://travis-ci.org/raspberrypi/documentation/builds/33774245 works absolutely fine with html-proofer 1.3.3 :-)
from html-proofer.
Phew, glad it worked!
Also: super stoked RaspberryPi is using this: https://twitter.com/gjtorikian/status/494546083666604032
from html-proofer.
Fantastic.
from html-proofer.
I get this problem when the link doesn't have a "/" at the end to a full domain. I don't think that's how it should work, unless I am missing something, but since the browser handles that problem, it shouldn't be enforced.
from html-proofer.
The reason I think it shouldn't work this way is because the only way to normalize URL's is with Ruby (in Jekyll) and of course I can in my own plugin, but within another authors plugin this becomes a PITA see:
- site/2013/06/24/mocking-activerecord-to-test-concerns.html
* internally linking to https://envygeeks.io//, which does not exist (line 79)
<a href="https://envygeeks.io//">Jordon Bedwell</a>
<p class="author">
<a href="{{ post.stat.author.website }}/">
{{ post.stat.author.name }}
</a>
</p>
It becomes even more strenuous when dealing with data from another domain.
from html-proofer.
To add, I guess this could be a mixture of internal_domains
and otherwise.
from html-proofer.
Related Issues (20)
- Fails multi email mailto
- Add --ignore-internal flag HOT 4
- Error for http only sites HOT 5
- allow_missing_href started giving false positives since v4.3 HOT 2
- cyn.eth
- HTTP 302 (to the same URL?) reported as failures HOT 2
- Error during deployment with scheme format HOT 3
- Question - setting up html proofer to skip new pages added to a website which will return a 404 HOT 3
- "ERROR: Invalid predicate" on ugly Maven search URL HOT 2
- Manager
- Small extra hint for beginners HOT 2
- Ruby 3.3.0 parameters bug HOT 3
- CI output disappeared when running htmlproofer, only raw logs show errors HOT 1
- The regex in Attribute::URL.clean_url is very slow for JavaScript bookmarklet URLs HOT 2
- Allow color in non tty shell HOT 7
- Link checker triggered on <a name="..."> and <a id="..."> HOT 6
- Want documentation (or even feature?) to parallelize local scans HOT 1
- Configuration by file? HOT 1
- Hash checker expects # in `id` HOT 1
- swap_attributes not working HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from html-proofer.