Support for ActiveSupport 4 about html-pipeline HOT 7 CLOSED

Happy to take a pull to relax the requirement if you have time. Otherwise,
will be doing some hacking on this gem tomorrow evening anyways.

On Wednesday, August 14, 2013, Chad Humphries wrote:

We were upgrading from 0.0.14 to 0.2.0, but got blocked by the gemspec
requirement on activesupport 3 or earlier.

Bundler could not find compatible versions for gem "activesupport":
In Gemfile:
html-pipeline (~> 0.1.0) ruby depends on
activesupport (< 4, >= 2) ruby

rails (~> 4.0) ruby depends on
  activesupport (4.0.0)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/76
.

-Jerry
@whatcodecraves http://twitter.com/whatcodecraves
github http://github.com/jch

from html-pipeline.

I'm likely not to have time until next week at this point. If it's still
open then I'll submit a PR.

On Wed, Aug 14, 2013 at 1:25 PM, Jerry Cheung [email protected]:

Happy to take a pull to relax the requirement if you have time. Otherwise,
will be doing some hacking on this gem tomorrow evening anyways.

On Wednesday, August 14, 2013, Chad Humphries wrote:

We were upgrading from 0.0.14 to 0.2.0, but got blocked by the gemspec
requirement on activesupport 3 or earlier.

Bundler could not find compatible versions for gem "activesupport":
In Gemfile:
html-pipeline (~> 0.1.0) ruby depends on
activesupport (< 4, >= 2) ruby

rails (~> 4.0) ruby depends on
activesupport (4.0.0)

—
Reply to this email directly or view it on GitHub<
https://github.com/jch/html-pipeline/issues/76>
.

-Jerry
@whatcodecraves http://twitter.com/whatcodecraves
github http://github.com/jch

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/76#issuecomment-22652120
.

from html-pipeline.

I've unpacked the gem after building locally and it looks like these version requirements are getting written in at build time. So if you build the gem with 1.9.3 or greater you get one set of requirements, 1.8.7 another, etc.

from html-pipeline.

I'll take a look at this now, and get back to you.

from html-pipeline.

It looks like ActiveSupport requires a minimum of Ruby 1.9.3. What version of Ruby are you using?

from html-pipeline.

Realized that ActiveSupport isn't even a hard dependency. I've moved it into a development dependency and cut 0.2.1. Feel free to reopen if it's still an issue for you.

from html-pipeline.

Cool, thanks!

from html-pipeline.