Code Monkey home page Code Monkey logo

Comments (4)

jch avatar jch commented on September 22, 2024

That's a nasty gotcha. The MarkdownFilter documentation does specify it needs to be the first filter in the pipeline, but this information needs to be more discoverable. We can pass in the Pipeline instance into the context hash for filters to do more introspection. Would you be interested in creating a pull for that?

from html-pipeline.

mtodd avatar mtodd commented on September 22, 2024

One possibility would be to rescue TypeError inside the MarkdownFilter and issue a custom warning, reminding those that see it that the MarkdownFilter needs to be first in the pipeline (which isn't entirely accurate anyways: it just needs to be the last TextFilter since it changes the source from text to HTML).

from html-pipeline.

mtodd avatar mtodd commented on September 22, 2024

@envygeeks I wrote up some quick recommended changes for your example: https://gist.github.com/mtodd/216223f2307634e78e7b

Let me know if you have any questions on normal usage.

from html-pipeline.

jch avatar jch commented on September 22, 2024

@mtodd Thanks for helping out! 🍻

from html-pipeline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.