Comments (10)
This is a hairy issue that I'm on the fence about. I'd rather keep this as a monolithic gem that includes all the filters and all of it's dependencies, but syntax highlighting adds several dependencies. Even if the pull request you mentioned maintains a branch with a statically linked binary build, I would not be able to reference it from the gemspec unless there was also a corresponding release to go with it (something like charlock_holmes 0.7.0.static
)
I'll leave this issue open for now and let others chime in after the holiday season. Thanks for bringing this issue back up!
from html-pipeline.
Just to add a bit of context, that branch on charlock_holmes is almost unusable on Heroku: it adds ~5-10 minutes to standard deploys.
from html-pipeline.
Can we just make a heroku buildpack for this?
The 5-10 minute build time should only be annoying on the first push, maybe force pushes too.
from html-pipeline.
@atmos https://github.com/minefold/mutli-buildpack-icu4c - 1 step ahead of you there. charlock holmes needs to be modified to pick it up (however) and that's not trivial. I gave up when I realised that it was only required by linguist. Here's my (messy) attempt. Oh, and that buildpack assumes that you're using hero-buildpack-multi.
from html-pipeline.
@chrislloyd I have a vulcan build of icu4c we should be able to extract into https://github.com/atmos/heroku-buildpack-ruby/tree/ffmpeg. The buildpack is here, http://atmos-s3itch.s3.amazonaws.com/atmos-heroku-buildpack-ruby-0.0.12.tgz.
Can vulcan list builds that you have? I think I nuked the repo I was testing with. /cc @ddollar
from html-pipeline.
That's definitely an option, though I strayed away from doing so because I didn't want to fork the Ruby language pack for our production app. It would be awesome if the buildpack-mutli sourced previous .profileds between each compilation step. buildpack-icu4c could then export LDFLAGS
and LD_LIBRARY_PATH
vars for the gem install
step /cc @ddollar. That would definitely make life easier.
On 27/12/2012, at 8:27 PM, Corey Donohoe [email protected] wrote:
@chrislloyd I have a vulcan build of icu4c we should be able to extract into https://github.com/atmos/heroku-buildpack-ruby/tree/ffmpeg. The buildpack is here, http://atmos-s3itch.s3.amazonaws.com/atmos-heroku-buildpack-ruby-0.0.12.tgz.
Can vulcan list builds that you have? I think I nuked the repo I was testing with. /cc @ddollar
—
Reply to this email directly or view it on GitHub.
from html-pipeline.
+1
from html-pipeline.
Sounds like this is enough of a pain to warrant a new release. I fixed in #35 and released 0.0.7 http://rubygems.org/gems/html-pipeline
🍻
from html-pipeline.
💯 × 🍻
Thank you very much!
from html-pipeline.
👍 Thanks for doing this. 👏
from html-pipeline.
Related Issues (20)
- 2.14.0 is disconnected HOT 4
- Allow `loading` attribute on images HOT 5
- Since bump 2.14.2 builds are failing HOT 3
- Allow vertical-align HOT 1
- Indicate a version for activesupport that has support/receives security patches (>= 6?) HOT 2
- v3: Question regarding requiring a ConvertFilter if there are NodeFilters HOT 1
- v3 gemoji, gemojione seem required - is there a way to not require at puma startup? HOT 2
- Suggestion: add more tags to the sanitization filter HOT 3
- So what DOES GitHub use now? HOT 1
- ActionView::Template::Error with version 3.0.0 HOT 8
- Bug in specification of node filters in v3.0.0 HOT 1
- convert_filter only executed when node_filters are present HOT 3
- Can't seem to get a <script> to run when added to the allowlist? HOT 2
- Error when passing instance of `TextFilter` class to `text_filters` option HOT 3
- Context & result of filters except for text_filters aren't overwritten on call time HOT 3
- Sanitizing inline style attributes HOT 2
- Question about original and new SanitizationFilter HOT 2
- Why are node_filters applied twice? HOT 3
- Update to 3.3.4? HOT 2
- v3.2.1 is badly broken, I think because of PR #408 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from html-pipeline.