Comments (8)
cc/ @gjtorikian @mdiep
from html-pipeline.
It looks like it is thinking the Right Double Quotation Mark is part of the email address when doing the autolink. This could be related to this bug. vmg/redcarpet#388
from html-pipeline.
@ericgoodwin do you have a backtrace of the error?
from html-pipeline.
Not sure it's much help because there is only one line that isn't Pry, but here it is.
[2] pry(main)> renderer.to_html("β[email protected]β").split
ArgumentError: invalid byte sequence in UTF-8
from (pry):2:in `split'
[3] pry(main)> wtf
Exception: ArgumentError: invalid byte sequence in UTF-8
--
0: (pry):2:in `split'
1: (pry):2:in `__pry__'
2: /Users/ericgoodwin/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/pry-0.10.1/lib/pry/pry_instance.rb:355:in `eval'
3: /Users/ericgoodwin/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/pry-0.10.1/lib/pry/pry_instance.rb:355:in `evaluate_ruby'
4: /Users/ericgoodwin/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/pry-0.10.1/lib/pry/pry_instance.rb:323:in `handle_line'
The error can also be created by just using github-markdown as well.
[7] pry(main)> GitHub::Markdown.to_html("β[email protected]β", :gfm).split
ArgumentError: invalid byte sequence in UTF-8
from (pry):4:in `split'
from html-pipeline.
Just found out it's an issue with Ruby versions as well.
Pasting the same text ("β[email protected]β"
) into irb Ruby 1.9 vs 2.1.3
Ruby 2.1.3
irb(main):001:0> "β[email protected]β"
=> "β[email protected]β"
Ruby 1.9
irb(main):001:0> "\[email protected]\U+FFE2"
=> "[email protected]"
It would appear that Ruby 1.9 is converting the characters automatically.
from html-pipeline.
@ericgoodwin π thanks for digging in. I'm going to close this issue for now because I can't think of anything specific to take action on. If you find more details about the encoding, please continue to comment here. I'm happy to reopen if there is a fix that can be applied against the gem.
from html-pipeline.
@jch Ok. Wasn't quite sure where to post this in the first place. I might keep on adding a few comments on here if that's ok with you so anyone else who runs into the issue can find some information on it. The issue seems to be with the github-markdown binary.
from html-pipeline.
π Yep keep 'em coming
from html-pipeline.
Related Issues (20)
- 2.14.0 is disconnected HOT 4
- Allow `loading` attribute on images HOT 5
- Since bump 2.14.2 builds are failing HOT 3
- Allow vertical-align HOT 1
- Indicate a version for activesupport that has support/receives security patches (>= 6?) HOT 2
- v3: Question regarding requiring a ConvertFilter if there are NodeFilters HOT 1
- v3 gemoji, gemojione seem required - is there a way to not require at puma startup? HOT 2
- Suggestion: add more tags to the sanitization filter HOT 3
- So what DOES GitHub use now? HOT 1
- ActionView::Template::Error with version 3.0.0 HOT 8
- Bug in specification of node filters in v3.0.0 HOT 1
- convert_filter only executed when node_filters are present HOT 3
- Can't seem to get a <script> to run when added to the allowlist? HOT 2
- Error when passing instance of `TextFilter` class to `text_filters` option HOT 3
- Context & result of filters except for text_filters aren't overwritten on call time HOT 3
- Sanitizing inline style attributes HOT 2
- Question about original and new SanitizationFilter HOT 2
- Why are node_filters applied twice? HOT 3
- Update to 3.3.4? HOT 2
- v3.2.1 is badly broken, I think because of PR #408 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from html-pipeline.