Code Monkey home page Code Monkey logo

Comments (8)

jbarnette avatar jbarnette commented on September 22, 2024

https://github.com/github/html-pipeline/blob/master/script/bootstrap#L4isn't
good. It should just bail with a friendly message if bundle isn't
in the path.

I'm not sure I understand the point of --standalone either.

The bundler dep in
https://github.com/github/html-pipeline/blob/master/Gemfile#L7 isn't
necessary. The :development, :test group for rake is also not really
needed: Just :development is fine.

Seems like the copyright in LICENSE should be for GitHub, Inc. and Jerry
Cheung.

The README needs an example of a require.

The gemspec isn't named correctly. It should be html-pipeline, not
github-html.

The author, author email, and homepage in the gemspec need to be fixed. The
content discovery for the gemspec is also a bit suspect: See
https://github.com/github/egress/blob/master/egress.gemspec for a bit more
straightforward of an approach.

I'm happy to do PRs for this stuff, but since you asked. :)

On Sun, Nov 4, 2012 at 11:45 AM, Jerry Cheung [email protected]:

I think this repo is ready for [image: 🚒]ing. #6https://github.com/github/html-pipeline/issues/6extracted this project from .com, and removed GitHub specific references in
the gem. Here's a list of remaining things I'd like to do before I share
the [image: ❀️] with the world:

  • update the readme
  • write a blog post with some examples
  • add travis
  • transfer ownership to jch (per @rtomaykohttps://github.com/rtomayko,
    having a maintainer rather than putting it under the org)

Is there anything I'm missing?

β€”
Reply to this email directly or view it on GitHubhttps://github.com/github/html-pipeline/issues/12.

from html-pipeline.

jch avatar jch commented on September 22, 2024

@jbarnette I'm thinking of removing script/bootstrap entirely. It's a GitHub specific convention and not necessary for the open source gem. Thoughts?

from html-pipeline.

jbarnette avatar jbarnette commented on September 22, 2024

I don't mind having script/boostrap exist, I think isolated deps are a good
thing for gem development. It's definitely not vital to keep around if it's
bothering you, though.

On Sun, Nov 4, 2012 at 3:40 PM, Jerry Cheung [email protected]:

@jbarnette https://github.com/jbarnette I'm thinking of removing
script/bootstrap entirely. It's a GitHub specific convention and not
necessary for the open source gem. Thoughts?

β€”
Reply to this email directly or view it on GitHubhttps://github.com/github/html-pipeline/issues/12#issuecomment-10057324.

from html-pipeline.

jbarnette avatar jbarnette commented on September 22, 2024

Weird, our email stuff collapsed a bunch of my other comments in that first bit. Might want to expand that and take a look if you didn't already.

from html-pipeline.

jch avatar jch commented on September 22, 2024

@jbarnette strange indeed. Awesome suggestions for cleanup, I'll add those as well. Next time I'll definitely rope you into some slave gem chores ;)

from html-pipeline.

derekgr avatar derekgr commented on September 22, 2024

Minor, but noticed the contributors list in README.md is missing mailto:'s for the links, so they get formatted like:

https://github.com/jch/html-pipeline/[email protected]

from html-pipeline.

tmm1 avatar tmm1 commented on September 22, 2024

I also noticed a link to the private repo github/camo instead of atmos/camo

from html-pipeline.

jch avatar jch commented on September 22, 2024

Thanks for the input all! Closing this now.

from html-pipeline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.