Comments (8)
https://github.com/github/html-pipeline/blob/master/script/bootstrap#L4isn't
good. It should just bail with a friendly message if bundle
isn't
in the path.
I'm not sure I understand the point of --standalone
either.
The bundler dep in
https://github.com/github/html-pipeline/blob/master/Gemfile#L7 isn't
necessary. The :development, :test group for rake is also not really
needed: Just :development is fine.
Seems like the copyright in LICENSE should be for GitHub, Inc. and Jerry
Cheung.
The README needs an example of a require
.
The gemspec isn't named correctly. It should be html-pipeline
, not
github-html
.
The author, author email, and homepage in the gemspec need to be fixed. The
content discovery for the gemspec is also a bit suspect: See
https://github.com/github/egress/blob/master/egress.gemspec for a bit more
straightforward of an approach.
I'm happy to do PRs for this stuff, but since you asked. :)
On Sun, Nov 4, 2012 at 11:45 AM, Jerry Cheung [email protected]:
I think this repo is ready for [image: π’]ing. #6https://github.com/github/html-pipeline/issues/6extracted this project from .com, and removed GitHub specific references in
the gem. Here's a list of remaining things I'd like to do before I share
the [image: β€οΈ] with the world:
- update the readme
- write a blog post with some examples
- add travis
- transfer ownership to jch (per @rtomaykohttps://github.com/rtomayko,
having a maintainer rather than putting it under the org)Is there anything I'm missing?
β
Reply to this email directly or view it on GitHubhttps://github.com/github/html-pipeline/issues/12.
from html-pipeline.
@jbarnette I'm thinking of removing script/bootstrap
entirely. It's a GitHub specific convention and not necessary for the open source gem. Thoughts?
from html-pipeline.
I don't mind having script/boostrap exist, I think isolated deps are a good
thing for gem development. It's definitely not vital to keep around if it's
bothering you, though.
On Sun, Nov 4, 2012 at 3:40 PM, Jerry Cheung [email protected]:
@jbarnette https://github.com/jbarnette I'm thinking of removing
script/bootstrap entirely. It's a GitHub specific convention and not
necessary for the open source gem. Thoughts?β
Reply to this email directly or view it on GitHubhttps://github.com/github/html-pipeline/issues/12#issuecomment-10057324.
from html-pipeline.
Weird, our email stuff collapsed a bunch of my other comments in that first bit. Might want to expand that and take a look if you didn't already.
from html-pipeline.
@jbarnette strange indeed. Awesome suggestions for cleanup, I'll add those as well. Next time I'll definitely rope you into some slave gem chores ;)
from html-pipeline.
Minor, but noticed the contributors list in README.md is missing mailto:'s for the links, so they get formatted like:
https://github.com/jch/html-pipeline/[email protected]
from html-pipeline.
I also noticed a link to the private repo github/camo instead of atmos/camo
from html-pipeline.
Thanks for the input all! Closing this now.
from html-pipeline.
Related Issues (20)
- 2.14.0 is disconnected HOT 4
- Allow `loading` attribute on images HOT 5
- Since bump 2.14.2 builds are failing HOT 3
- Allow vertical-align HOT 1
- Indicate a version for activesupport that has support/receives security patches (>= 6?) HOT 2
- v3: Question regarding requiring a ConvertFilter if there are NodeFilters HOT 1
- v3 gemoji, gemojione seem required - is there a way to not require at puma startup? HOT 2
- Suggestion: add more tags to the sanitization filter HOT 3
- So what DOES GitHub use now? HOT 1
- ActionView::Template::Error with version 3.0.0 HOT 8
- Bug in specification of node filters in v3.0.0 HOT 1
- convert_filter only executed when node_filters are present HOT 3
- Can't seem to get a <script> to run when added to the allowlist? HOT 2
- Error when passing instance of `TextFilter` class to `text_filters` option HOT 3
- Context & result of filters except for text_filters aren't overwritten on call time HOT 3
- Sanitizing inline style attributes HOT 2
- Question about original and new SanitizationFilter HOT 2
- Why are node_filters applied twice? HOT 3
- Update to 3.3.4? HOT 2
- v3.2.1 is badly broken, I think because of PR #408 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from html-pipeline.