AutolinkFilter link_attr doesn't seem to work about html-pipeline HOT 3 CLOSED

The attribute should be passed straight through to rinku. Could you try running the code against just Rinku in console?

from html-pipeline.

Hi,
when using the filters without MarkdownFilter it is working:

context = {
      asset_root: 'https://a248.e.akamai.net/assets.github.com/images/icons/',
      link_attr: 'target="_blank"',
      gfm: true
    }

    pipeline = HTML::Pipeline.new [
      HTML::Pipeline::SanitizationFilter,
      HTML::Pipeline::EmojiFilter,
      HTML::Pipeline::AutolinkFilter
    ], context

the input text is a basic "hi, please visit http://github.com"

Thanks,
Roy

from html-pipeline.

The github-markdown gem converts "http://github.com" in your input to a link. When Rinku sees that the link is already wrapped in an anchor tag, it ignores it and doesn't try to wrap it again. I agree this is annoying, but it's out of scope for this gem because it depends on the implementation of github-markdown and rinku. If you have a suggested fix, I'd be happy to review a pull request.

from html-pipeline.