Comments (16)
Hi @josephzidell!
Please gist your raw markdown document, so I can try to reproduce. Thanks.
from html-pipeline.
Sure. It's a blog post https://gist.github.com/josephzidell/8816548
from html-pipeline.
@josephzidell I'm sorry, but I don't see the extra white space. It's not in your gist. I created a testing gist, and the CSS looks good. Maybe, your implementation is adding the white space?
from html-pipeline.
@simeonwillbanks Thanks for your help. How would I determine if my "implementation" is adding the white space?
from html-pipeline.
@josephzidell Let's try a few things:
- Double check your CSS styles; is a padding or a margin being added?
- Add
result[:output].to_s
to your gist - Run
bundle exec nokogiri -v
and paste output into this issue - Paste more relevant implementation code into this issue
Thanks!
from html-pipeline.
@simeonwillbanks Thanks so much for your help. I trimmed down the problem to just a single line.
-
It's actual spaces, highlightable via a mouse
-
Here's a new gist with everything.
-
nokogiri version
$ bundle exec nokogiri -v
Nokogiri (1.6.1)
--- warnings: [] nokogiri: 1.6.1 ruby: version: 2.0.0 platform: x86_64-linux description: ruby 2.0.0p353 (2013-11-22 revision 43784) [x86_64-linux] engine: ruby libxml: binding: extension source: packaged libxml2_path: /home/wwc/.rvm/gems/ruby-2.0.0-p353/gems/nokogiri-1.6.1/ports/x86_64-linux-gnu/libxml2/2.8.0 libxslt_path: /home/wwc/.rvm/gems/ruby-2.0.0-p353/gems/nokogiri-1.6.1/ports/x86_64-linux-gnu/libxslt/1.1.26 compiled: 2.8.0 loaded: 2.8.0
-
That's it!
from html-pipeline.
@josephzidell Thanks for the info, but I'm still unable to reproduce.
Your markdown is sent to GitHub::Markdown. Maybe it's the source of the issue? Please try this in your rails console:
markdown = @post.body_markdown
pipeline = HTML::Pipeline.new [HTML::Pipeline::MarkdownFilter]
pipeline.call(markdown)[:output].to_s
#=> "<pre lang=\"html\"><code><a href="mailto:[email protected]?subject=Hi!&amp;amp;body=Either type the email address or use the form. Thanks!"></a>\n</code></pre>"
GitHub::Markdown.to_html(markdown, :gfm)
#=> "<pre lang=\"html\"><code><a href="mailto:[email protected]?subject=Hi!&amp;amp;body=Either type the email address or use the form. Thanks!"></a>\n</code></pre>\n"
from html-pipeline.
Closing from inactivity. Feel free to re-open if you still need help.
from html-pipeline.
This is still an issue, that I'd like to get fixed.
Due to the length of time here, I actually implemented the web app in PHP instead of rails :( to get around this problem.
Followed @simeonwillbanks's instructions: no extra spaces there.
from html-pipeline.
@josephzidell If you tried my two examples and you didn't see extra spaces, it sounds like html-pipeline
isn't the culprit. Maybe the issue is with raw
?
from html-pipeline.
After some playing around, the issue certainly seems to be with raw
. So it's not an issue with html-pipeline
.
The question is: what to do?
from html-pipeline.
@josephzidell you might want to try your question over at stackoverflow.com too
from html-pipeline.
@josephzidell I second trying on stackoverflow.com.
from html-pipeline.
Will do. Thanks, guys. Here's a link to the question. Thanks, guys!
from html-pipeline.
As you can see, it's actually a HAML issue. Thanks again.
from html-pipeline.
Good to know. Thanks!
from html-pipeline.
Related Issues (20)
- Canalizacion de HTML
- Html-pipeline
- I would love to use the vscode codicon.ttf in my readme.md HOT 1
- 2.14.0 is disconnected HOT 4
- Allow `loading` attribute on images HOT 5
- Since bump 2.14.2 builds are failing HOT 3
- Allow vertical-align HOT 1
- Indicate a version for activesupport that has support/receives security patches (>= 6?) HOT 2
- v3: Question regarding requiring a ConvertFilter if there are NodeFilters HOT 1
- v3 gemoji, gemojione seem required - is there a way to not require at puma startup? HOT 2
- Suggestion: add more tags to the sanitization filter HOT 3
- So what DOES GitHub use now? HOT 1
- ActionView::Template::Error with version 3.0.0 HOT 8
- Bug in specification of node filters in v3.0.0 HOT 1
- convert_filter only executed when node_filters are present HOT 3
- Can't seem to get a <script> to run when added to the allowlist? HOT 2
- Error when passing instance of `TextFilter` class to `text_filters` option HOT 3
- Context & result of filters except for text_filters aren't overwritten on call time HOT 3
- Sanitizing inline style attributes HOT 1
- Question about original and new SanitizationFilter HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from html-pipeline.