Comments (6)
Hmmm, ya this line https://github.com/jch/html-pipeline/blob/master/lib/html/pipeline/camo_filter.rb#L25 should return doc
. I noticed that the disable_asset_proxy
option is not currently documented. I'm not sure if disabling filters at runtime is common, but maybe it makes more sense to generalize this functionality at the Pipeline level rather than at the Filter level:
SomePipeline = HTML::Pipeline.new [
HTML::Pipeline::CamoFilter,
HTML::Pipeline::MarkdownFilter
]
SomePipeline.call("some input content", :disable_filters => [:camo])
Thoughts?
from html-pipeline.
@jch At the moment we are using it to disable the filter in enterprise land, but keep it everywhere else. I think a higher level disable filters could be great as well.
from html-pipeline.
from html-pipeline.
@josh thanks for the fix, could you put them in PR's in the future? I like to link to specific PR's in the change logs.
from html-pipeline.
Yeah, sorry, it was a quick fix for .com purposes. We just hit the same issue, d'oh! But I kinda agree about just removing the filter if you aren't using it.
from html-pipeline.
Closing. Slated for the next release v1.6.0. Waiting on #105 before I cut that.
from html-pipeline.
Related Issues (20)
- 2.14.0 is disconnected HOT 4
- Allow `loading` attribute on images HOT 5
- Since bump 2.14.2 builds are failing HOT 3
- Allow vertical-align HOT 1
- Indicate a version for activesupport that has support/receives security patches (>= 6?) HOT 2
- v3: Question regarding requiring a ConvertFilter if there are NodeFilters HOT 1
- v3 gemoji, gemojione seem required - is there a way to not require at puma startup? HOT 2
- Suggestion: add more tags to the sanitization filter HOT 3
- So what DOES GitHub use now? HOT 1
- ActionView::Template::Error with version 3.0.0 HOT 8
- Bug in specification of node filters in v3.0.0 HOT 1
- convert_filter only executed when node_filters are present HOT 3
- Can't seem to get a <script> to run when added to the allowlist? HOT 2
- Error when passing instance of `TextFilter` class to `text_filters` option HOT 3
- Context & result of filters except for text_filters aren't overwritten on call time HOT 3
- Sanitizing inline style attributes HOT 2
- Question about original and new SanitizationFilter HOT 2
- Why are node_filters applied twice? HOT 3
- Update to 3.3.4? HOT 2
- v3.2.1 is badly broken, I think because of PR #408 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from html-pipeline.