Code Monkey home page Code Monkey logo

Comments (3)

pd431 avatar pd431 commented on August 14, 2024

Realised that this modification makes images escape their boxes, so I've adjusted the fixes:

.grid-section.card{
   max-width: 48%;
   overflow: hidden;
}

.format-grid .thegrid .grid-image img{
   max-width: 100%;
}

This seems to work.

from moodle-format_grid.

gjb2048 avatar gjb2048 commented on August 14, 2024

I'll admit that this solution does appear to work in terms of the limited testing I have done. However, it does mean that it's possible for a setting of 210px that the box will be 206px and thus the user is not getting what they expected.

from moodle-format_grid.

pd431 avatar pd431 commented on August 14, 2024

I hadn't considered that.

The main reason I'd specify a non default setting on the image container width is to change how many cards I have a side.
In term of user story, the fact that this wouldn't be respected wouldn't be such an issue for me.

Where it could cause an issue would be where I specified a very large width, and a wide aspect ratio, and ended up with a squished card, expecting the cards to be on top of each other nicely.

Maybe a toggle for Minimum numbber of cards aside (with a better name) that then toggles this styling?

from moodle-format_grid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.