Comments (7)
I would be fine with changing the default, since it was implemented before we ran into some of our own troubles with Auto Layout as well.
It'd be nice to have a consistent subview layout hook on 10.7 and 10.8, though. I've done this with -resizeSubviewsWithOldSize:
, but that seems unlikely to work with views that do use Auto Layout.
from rebel.
Lets lay out what I think is happening here:
On OS X 10.8:
resizeSubviewsWithOldSize:
is called without auto layoutresizeSubviewsWithOldSize:
is not called with auto layoutlayout
is called without auto layoutlayout
is called with auto layout
On OS X 10.7:
resizeSubviewsWithOldSize:
is called without auto layoutresizeSubviewsWithOldSize:
is not called with auto layoutlayout
is not called without auto layoutlayout
is called with auto layout
Not sure where to go from here. We could do an #ifdef and enable the resizeSubviewsWithOldSize:
code if we're on anything less than 10.7. Any ideas?
from rebel.
At this point, the only thing that occurs to me is an overridable method named layoutSubviews
, which is invoked from whichever layout hooks we might get (without OS conditionalizing).
That's sucky and confusing, though, and makes me think this responsibility should just lie on the user of the class.
from rebel.
I'm just desperately thinking of ways we could get rid of the enabling of constraints as that causes no end of problems.
from rebel.
Agree here, constraints cause a whole host of problems. Literally no existing code works with constraints layout enabled without some serious tweaking. I think either @jwilling's conditional or just diverting the layout responsibilities from RBLView
to the subclass would be the best solutions.
from rebel.
@jwilling I wasn't disagreeing with changing the default return value of that method. I just think there's no way we can compensate for it elsewhere given the shitty layout APIs.
So, let's just remove any default layout code from RBLView
.
from rebel.
from rebel.
Related Issues (20)
- Cannot build archive "error: -fobjc-arc is not supported on platforms using the legacy runtime" HOT 4
- Concerns about -prepareForReuse in RBLTableCellView HOT 13
- Blocks category for NSAlert/NSMenuItem HOT 3
- RBLHTMLView spinning the run loop HOT 2
- Removing an RBLView from superview make the application crash HOT 1
- Crashes on 10.8 due to dealloced rbl_viewController HOT 2
- Weak rbl_viewController reference causing EXC_BAD_ACCESS errors HOT 3
- RBLPopover Transient Behavior not behaving right as documented HOT 1
- Is it possible to completely hide arrow? HOT 4
- viewDidMoveToSuperview and viewDidMoveToWindow doesn't get called on controller when using RBLView HOT 1
- Update RBLPopover when contentSize changes
- Update version for cocoapods HOT 4
- Abandon Rebel? HOT 7
- Cannot build Rebel via Carthage HOT 3
- RBLResizableImage appears to not render correctly for small images (eg, 1px wide). HOT 5
- RBLResizableImage scales 2x images down to 1x yielding yucky visual artifacts. HOT 10
- Replace RBLViewController with block callbacks HOT 1
- Can we get a new tag? HOT 2
- RBLPopover doesn't dismiss when clicking outside of it from an NSStatusItem HOT 8
- RBLPopover setContentSize won't resize the Popover dynamically like in NSPopover HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rebel.