Code Monkey home page Code Monkey logo

Comments (9)

gitbls avatar gitbls commented on September 7, 2024 1

It WAS working, but then I "improved" it, broke it, and clearly failed to retest multiple invocations of the plugin.

Will fix later this morning USPT.

from sdm.

gitbls avatar gitbls commented on September 7, 2024

Fixed in V8.6. You can simply re-run EZsdmInstaller to pick it up.

from sdm.

nzottmann avatar nzottmann commented on September 7, 2024

In my first try it didn't work at all now, but I'm still figuring out if this is my fault or not. Will report back after checking.

from sdm.

gitbls avatar gitbls commented on September 7, 2024

In my first try it didn't work at all now, but I'm still figuring out if this is my fault or not. Will report back after checking.

If you can't sort it out, post the sdm command you're working with I can have a look at it.

from sdm.

nzottmann avatar nzottmann commented on September 7, 2024

Thank you, I tested more and it seems to be a problem with the changes to the copyfile plugin.

This is my sdm command:
sudo sdm --customize --plugin copyfile:"from=$PWD/050-test.sh|to=/usr/local/sdm/1piboot/|mkdirif=yes|chown=root:root|chmod=755" 2023-05-03-raspios-bullseye-armhf-lite.img
The file 050-test.sh and the image are in my working dir.

Using the old copyfile https://github.com/gitbls/sdm/blob/fcca7014105b3d6f801bbb1f89ab04674523201c/plugins/copyfile, the file ends up in the image. Using the new copyfile https://github.com/gitbls/sdm/blob/e24a533f6d693b73c83cd9c2bf37a1e4d9cae3bf/plugins/copyfile, the file is missing in the image. You can also see a difference in the relevant sections of the log output, with the new version, the lines where it actually copies the file are missing:

Old copyfile, working:

> Run Plugin 'copyfile' (/mnt/sdm/usr/local/sdm/plugins/copyfile) Phase 0 with arguments:
  'from=/workingdir/050-test.sh|to=/usr/local/sdm/1piboot/|mkdirif=yes|chown=
  root:root|chmod=755'
* Plugin copyfile: Start Phase 0
> Plugin copyfile: Keys/values found:
   from: /workingdir/050-test.sh
   to: /usr/local/sdm/1piboot/
   mkdirif: yes
   chown: root:root
   chmod: 755
> Plugin copyfile: Add '/workingdir/050-test.sh' to files to copy
* Plugin copyfile: Complete Phase 0

* Plugin copyfile: Start Phase 1
> Plugin copyfile: Copy '050-test.sh' from /etc/sdm/assets/copyfile to '/usr/local/sdm/1piboot/'
* Plugin copyfile: Complete Phase 1

> Run Plugin 'copyfile' (/usr/local/sdm/plugins/copyfile) Phase post-install with arguments:
  'from=/workingdir/050-test.sh|to=/usr/local/sdm/1piboot/|mkdirif=yes|chown=
  root:root|chmod=755'
* Plugin copyfile: Start Phase post-install
* Plugin copyfile: Complete Phase post-install

New copyfile, not working:

> Run Plugin 'copyfile' (/mnt/sdm/usr/local/sdm/plugins/copyfile) Phase 0 with arguments:
  'from=/workingdir/050-test.sh|to=/usr/local/sdm/1piboot/|mkdirif=yes|chown=
  root:root|chmod=755'
* Plugin copyfile: Start Phase 0
> Plugin copyfile: Keys/values found:
   from: /workingdir/050-test.sh
   to: /usr/local/sdm/1piboot/
   mkdirif: yes
   chown: root:root
   chmod: 755

> Run Plugin 'copyfile' (/usr/local/sdm/plugins/copyfile) Phase 1 with arguments:
  'from=/workingdir/050-test.sh|to=/usr/local/sdm/1piboot/|mkdirif=yes|chown=
  root:root|chmod=755'
* Plugin copyfile: Start Phase 1
* Plugin copyfile: Complete Phase 1

> Run Plugin 'copyfile' (/usr/local/sdm/plugins/copyfile) Phase post-install with arguments:
  'from=/workingdir/050-test.sh|to=/usr/local/sdm/1piboot/|mkdirif=yes|chown=
  root:root|chmod=755'
* Plugin copyfile: Start Phase post-install
* Plugin copyfile: Complete Phase post-install

from sdm.

gitbls avatar gitbls commented on September 7, 2024

It appears that I duffed an edit. There is a line with a "naked" exit on it in the plugin. Delete that line and append && exit to the line above it (logtoboth Nothing to Do).

Not sure how I managed that 😳, but it will be fixed in the next update

from sdm.

nzottmann avatar nzottmann commented on September 7, 2024

Oops 😀

After moving the exit, it works. Thank you for the quick help!

from sdm.

gitbls avatar gitbls commented on September 7, 2024

This is corrected in V9.1.1. Please test, verify, and close this issue.

from sdm.

nzottmann avatar nzottmann commented on September 7, 2024

I can confirm this is fixed in V9.5. Thank you!

from sdm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.