Code Monkey home page Code Monkey logo

Comments (13)

gitblit avatar gitblit commented on July 30, 2024
I just realised that by calling directly the URL  */summary/?r=<reponame> I can access
the summary page of each repository.

I'll try to identify the offending repository and to understand the differences from
a working repository

Reported by gm.romanato on 2011-07-22 14:43:58

from gitblit.

gitblit avatar gitblit commented on July 30, 2024
Evidently my exception logging needs some, ahem, improving.  :)  Whatever you can dig
up would be super helpful.  In the mean time I will improve the logging and trap the
NPE.

Reported by James.Moger on 2011-07-22 14:48:59

  • Status changed: Started

from gitblit.

gitblit avatar gitblit commented on July 30, 2024

Reported by James.Moger on 2011-07-22 14:49:12

  • Labels added: Milestone-0.5.2

from gitblit.

gitblit avatar gitblit commented on July 30, 2024
The problem occurs on newly created repositories that do not contain any commit.
After making the first commit the issue disappears.

While not critical, this is a very annoying issue.

Reported by gm.romanato on 2011-07-22 15:04:39

from gitblit.

gitblit avatar gitblit commented on July 30, 2024
That is interesting.  This case should already be covered.  Are you creating the repository
with Gitblit or something else?

Reported by James.Moger on 2011-07-22 15:19:04

from gitblit.

gitblit avatar gitblit commented on July 30, 2024
Let me rephrase that question.

Does the exception occur on the main repositories list/root page?

Or are you trying to directly view a repository-specific page, like the summary page
by entering the URL manually?

If its the latter, then this is related to issue 309 where I do not allow browsing empty
repositories (which is by design).  The difference is in issue 309 you outlined a scenario
where my check for empty is flawed.

Reported by James.Moger on 2011-07-22 15:28:29

from gitblit.

gitblit avatar gitblit commented on July 30, 2024
hi, we create repositories using standard git on linux.
The repository was created but still no commit executed.

if you browse directly the repository summary page you get the stacktrace above, but
the same happens if you browse gitblit home (I mean the index of all repositories)

Reported by gm.romanato on 2011-07-22 15:32:24

from gitblit.

gitblit avatar gitblit commented on July 30, 2024
Nevermind.  I see you were access the repository list.
I think I have trapped this problem and the proposed fix will be in the next release.

Reported by James.Moger on 2011-07-22 15:34:13

from gitblit.

gitblit avatar gitblit commented on July 30, 2024
Another update. I realised that my colleagues already created a branch in that repository,
and committed code to the branch, but nothing has been committed to master.
This is because the repository is being migrated from another VCS, and devs working
on an unstable branch committed first.

Reported by gm.romanato on 2011-07-22 15:37:30

from gitblit.

gitblit avatar gitblit commented on July 30, 2024
That explains it then.

In 0.5.1 the isEmpty check looks for files in the refs/heads folder.  If no files,
its empty.  If has files it has commits.  That fails with your native Git bare clone
option which does not create any refs (interestingly JGit bare clone works - they must
define it slightly different).

The upcoming revised isEmpty check will determine if there are loose objects in .git/objects
or packed objects in .git/objects/pack.

Both of these approaches will fail, though with what you just described.  The silver
lining is that the next release won't break on the repositories page, though the "last
change" will be wrong as its based on HEAD - which of course is flawed design for branchy
models.  Something else to add to the TODO list.

I'll try to setup a test repository like you've described with no master to see what
else breaks.

Reported by James.Moger on 2011-07-22 16:00:34

from gitblit.

gitblit avatar gitblit commented on July 30, 2024
I think I've fixed the bug.  I also changed the "last change" bit to reflect branches,
not just HEAD.  Attached to this issue is snapshot of the upcoming release.  It also
includes adjustments for your other issues.

If you experience unusual slowness on displaying the repositories list, try disabling
the new setting web.showRepositorySizes.

I still can't reproduce your branch log issue.  :(

Reported by James.Moger on 2011-07-22 16:57:59


- _Attachment: [gitblit-0.5.2-SNAPSHOT.zip](https://storage.googleapis.com/google-code-attachments/gitblit/issue-14/comment-11/gitblit-0.5.2-SNAPSHOT.zip)_

from gitblit.

gitblit avatar gitblit commented on July 30, 2024
Issue 299 has been merged into this issue.

Reported by James.Moger on 2011-07-25 20:11:46

from gitblit.

gitblit avatar gitblit commented on July 30, 2024

Reported by James.Moger on 2011-07-27 12:14:40

  • Status changed: Fixed

from gitblit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.