Code Monkey home page Code Monkey logo

Comments (5)

chrisd8088 avatar chrisd8088 commented on June 8, 2024

I haven't yet been able to reproduce this, at least on a local dev instance with a slightly older macOS version. Will keep looking.

from git-lfs.

chrisd8088 avatar chrisd8088 commented on June 8, 2024

So far I've narrowed down the culprit to a test we've had trouble with before, the "does not look in current directory for git with credential helper" test in t/t-path.sh.

It seems as though something about the temporary creation of a "fake Git", even though it's followed by an immediate removal, leads our lfstest-gitserver command, when it responds to the subsequent Git push, to get a non-response when it tries to run git http-backend. From the remote/gitserver.log file:

#    2024/04/09 23:06:12 [44042ae2-444d-3a6f-7309-160cba3f07f6] git http-backend POST /t-path-credentials/git-receive-pack
#    fatal: the remote end hung up unexpectedly
#    2024/04/09 23:06:12 exit status 1

Once the lfstest-gitserver has stopped, most subsequent tests and any ones running concurrently fail too.

from git-lfs.

chrisd8088 avatar chrisd8088 commented on June 8, 2024

Over the weekend and yesterday I was able to reproduce this consistently in CI without even using our "fake Git" program, just copying the actual git binary into the repo, adding and committing it, and trying to push it to our lfstest-gitserver. Both ends would then seem to get no response; the client doing the push, and the git-http-backend. Each reported a closed connection from the other end, it appeared.

Intriguingly, today I can't reproduce this at all in CI on a macOS runner, so I've re-run the failing job on PR #5698 and we'll see if that passes too.

from git-lfs.

chrisd8088 avatar chrisd8088 commented on June 8, 2024

CI seems to be back to normal. I suspect the issue here was outside our control, and some kind of security feature in GitHub Actions and/or macOS was detecting binaries (maybe unsigned binaries?) being sent to a socket over HTTP and shutting down the connection, so both sides just saw nothing, and then our lfstest-gitserver would, correctly, exit, causing most subsequent tests to fail.

That's purely a guess based on what I was seeing, but I'm inclined to close this and re-open it if the problem comes back.

from git-lfs.

bk2204 avatar bk2204 commented on June 8, 2024

Yup, that seems appropriate. I'll close this for now.

from git-lfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.