Code Monkey home page Code Monkey logo

Comments (8)

mjcheetham avatar mjcheetham commented on May 18, 2024 1

Yes, but the changes that fix this issue have not been released yet. Might be worth doing that.

from git-credential-manager.

mjcheetham avatar mjcheetham commented on May 18, 2024 1

Maybe a bit off-topic, but Bitbucket Server Datacenter supports SAML authentication against an external IDP.
This functionality can also be provided to regular Bitbucket Server by several marketplace plugins.
It would be great if GCMC could include support for this, in order to avoid the need to create user tokens.

Hey @agusmba! Although we cannot commit to implementing this, would you mind creating an issue (feature request) for supporting SAML with Bitbucket Server Datacenter? We'd also be happy to review and PRs implementing this 😁

Thanks!

from git-credential-manager.

agusmba avatar agusmba commented on May 18, 2024 1

#151 created for tracking that. Thanks!

from git-credential-manager.

dscho avatar dscho commented on May 18, 2024

@mminns I opened a PR with your changes here: #141. From my point of view, the changes are good to go. @mjcheetham what do you think?

from git-credential-manager.

mjcheetham avatar mjcheetham commented on May 18, 2024

Awesome @mminns! Thanks for this. Your POC looks good to me.
Thanks @dscho for opening the PR for the commit. I did submit some small requests to change things.

from git-credential-manager.

mminns avatar mminns commented on May 18, 2024

@mminns I opened a PR with your changes here: #141. From my point of view, the changes are good to go. @mjcheetham what do you think?

Wow, thanks. there was me thinking it probably needed some tests :)

I'll follow up the PR comments. 👍

from git-credential-manager.

dscho avatar dscho commented on May 18, 2024

Can this ticket be closed now?

from git-credential-manager.

agusmba avatar agusmba commented on May 18, 2024

Maybe a bit off-topic, but Bitbucket Server Datacenter supports SAML authentication against an external IDP.
This functionality can also be provided to regular Bitbucket Server by several marketplace plugins.
It would be great if GCMC could include support for this, in order to avoid the need to create user tokens.

from git-credential-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.