Comments (3)
Thanks for filing the issue. The result from your first example is indeed unexpected and needs to be investigated further. For reference here's the direct link to the OSM way.
As for your other examples, it's actually not a 🐛 but a feature 😂 This is so because in the first case the way which is tagged as highway=service
is categorized as WayType.STREET
and as such receives the assumed surface type paved
according to the logic in WaySurfaceTypeGraphStorageBuilder
:
In the case of the cycleway and footway the OSM tag highway=path
translates to WayType.PATH
which is assumed to be unpaved
by the above logic. This happens because tags such as footway:surface
or cycleway:surface
are currently not being parsed, just the surface
one.
from openrouteservice.
As for your other examples, it's actually not a 🐛 but a feature 😂 This is so because in the first case the way which is tagged as
highway=service
is categorized asWayType.STREET
and as such receives the assumed surface typepaved
according to the logic inWaySurfaceTypeGraphStorageBuilder
:
But this is wrong. Not every highway=service
is paved. One example could be a driveway which is supposed to be tagged as highway=service
+ service=driveway
, but in many cases is not paved, at least in Poland (wiki).
In the case of the cycleway and footway the OSM tag
highway=path
translates toWayType.PATH
which is assumed to beunpaved
by the above logic. This happens because tags such asfootway:surface
orcycleway:surface
are currently not being parsed, just thesurface
one.
Same as above, highway=path
doesn't mean the surface is unpaved. A good example is shared foot and bicycle paths, which are tagged highway=path
+ bicycle=designated
+ foot=designated
and are often made of asphalt or paving stones (wiki).
Anyway, road classification doesn't imply surface in any case, so I think this feature should be disabled.
from openrouteservice.
Related Issues (20)
- docs: Replace docker documentation with new jar-docker based one HOT 1
- Deprecate `fastest` preference
- `hgv=delivery`-tags not considered properly HOT 1
- Error when opening page with installation instructions HOT 2
- missing configuration options in docs and application.yml
- Overhaul country borders storage format
- Missing way in preprocessed test graph HOT 2
- ors.engine.profile_default in ors-config.yml is ignored
- Preparation mode does not exit successfully after mapgen is complete
- CVE-2024-22243 org.springframework:spring-web (ors.jar) HOT 1
- CVE-2024-22259 org.springframework:spring-web (ors.jar) HOT 1
- Migration info printed even if using yaml HOT 1
- Application startup fails org.yaml.snakeyaml.error.YAMLException: java.io.IOException: Is a directory HOT 1
- Not ready after ten a week of creating graph HOT 7
- Review configuration
- Improve track grade parsing
- Cannot find routable point HOT 1
- Consider side of road for departure and destination points HOT 1
- Support bicycle=destination for bike profiles HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openrouteservice.